Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for #34409] [$500] Android - Public room - Extra spacing above the room header #34050

Closed
1 of 6 tasks
lanitochka17 opened this issue Jan 5, 2024 · 35 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33829

Action Performed:

  1. Log out.
  2. Tap on public room link on a different app. (https://staging.new.expensify.com/r/2376199970894587)
  3. Log in to any account

Expected Result:

The room header has adequate spacing

Actual Result:

There is extra spacing above the room header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333402_1704477952176!Screenshot_20240106_020324

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011fc3d6204dc1c3d6
  • Upwork Job ID: 1745516903101734912
  • Last Price Increase: 2024-01-18
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 5, 2024

Triggered auto assignment to @blimpich (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@blimpich
Copy link
Contributor

blimpich commented Jan 5, 2024

I don't consider this a blocker, considering it only occurs on Android, is a fairly minor UI mishap, and only happens under very specific circumstances.

@blimpich blimpich added Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 5, 2024
Copy link

melvin-bot bot commented Jan 5, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Jan 5, 2024

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@situchan
Copy link
Contributor

situchan commented Jan 5, 2024

I am not able to reproduce on main

34050

@blimpich
Copy link
Contributor

blimpich commented Jan 5, 2024

Hmmm, interesting. Maybe we should close this issue then if its not reproducible on main.

@greg-schroeder
Copy link
Contributor

Fine with that especially given it's super niche

@kbecciv
Copy link

kbecciv commented Jan 10, 2024

Issue is reproducible on build 1.4.24.0 @situchan Did you check in physical device or emulator?

video_2024-01-10_12-55-28.mp4

@kbecciv kbecciv reopened this Jan 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2024
@blimpich
Copy link
Contributor

Not overdue. Waiting to hear back from @situchan before assigning this out to external contributors.

@melvin-bot melvin-bot bot removed the Overdue label Jan 11, 2024
@situchan
Copy link
Contributor

reproduced

header

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 11, 2024
@blimpich blimpich added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 11, 2024
@greg-schroeder greg-schroeder added Weekly KSv2 and removed Daily KSv2 labels Jan 22, 2024
@greg-schroeder
Copy link
Contributor

Held

@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2024
@greg-schroeder
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2024
@greg-schroeder
Copy link
Contributor

Same

@s77rt
Copy link
Contributor

s77rt commented Feb 8, 2024

Another case (diff reproduction steps) has been reported here #36010. Please make sure that one is covered.

@greg-schroeder
Copy link
Contributor

held

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@situchan
Copy link
Contributor

Holding PR was C+ approved today, not merged yet

@melvin-bot melvin-bot bot removed the Overdue label Feb 26, 2024
@greg-schroeder
Copy link
Contributor

PR was merged and deployed to prod

@greg-schroeder greg-schroeder added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Mar 2, 2024
@greg-schroeder
Copy link
Contributor

Let's retest to see if it works - I can't test this personally cause I don't have an android device, asking QA

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@greg-schroeder
Copy link
Contributor

Will bump QA

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@situchan
Copy link
Contributor

Looks like deep link is broken.
I am not able to go to public room with anonymous user on android phone. Stuck on login.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@greg-schroeder
Copy link
Contributor

I think I'm going to close this as QA can't repro

@greg-schroeder
Copy link
Contributor

Reopen if you disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants