-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-26] Room - Email in Concierge message is not copied when copied to clipboard #34504
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @danieldoglas ( |
Hm, what type of room is this? I created a workspace public room on my build that is before this one to confirm it works in production, and it never asked me if I wanted to invite the user. Then did the same on a private room, and it just invited without confirming. @lanitochka17 |
This is new feature from #33665. |
Thanks @situchan, and I agree. Assigning @jasperhuangg since he was responsible for the original issue as well |
I'll take a look 👀 |
This comment was marked as off-topic.
This comment was marked as off-topic.
@jasperhuangg Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Contributor has opened a PR, not overdue! |
Contributor is working on a draft PR, not overdue! |
@jasperhuangg Can you review changes on PR or assign a c+ to review and approve changes, i have mentioned you there but comment might be missed |
@ishpaul777 gotcha, sorry if I missed the ping. I've pinged the C+ channel to see if there are any takers for the review |
This issue has not been updated in over 15 days. @jasperhuangg eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-26. 🎊 |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
I am eligible for payment here |
Triggered auto assignment to @MitchExpensify ( |
@MitchExpensify Can we pay out @aimane-chnaif for PR review? |
Paid and contract ended! Can we close now @jasperhuangg ? |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The email in Concierge message is copied
Actual Result:
The email in Concierge message is not copied when copied to clipboard
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6342993_1705329405864.20240115_203555__1_.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: