Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-26] Room - Email in Concierge message is not copied when copied to clipboard #34504

Closed
6 tasks done
lanitochka17 opened this issue Jan 15, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Create a room
  2. Go to the room
  3. Send a text containing mention of a non-member user
  4. Right click on Concierge message > Copy to clipboard
  5. Paste the content

Expected Result:

The email in Concierge message is copied

Actual Result:

The email in Concierge message is not copied when copied to clipboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6342993_1705329405864.20240115_203555__1_.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 15, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 15, 2024

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@danieldoglas
Copy link
Contributor

Hm, what type of room is this? I created a workspace public room on my build that is before this one to confirm it works in production, and it never asked me if I wanted to invite the user. Then did the same on a private room, and it just invited without confirming. @lanitochka17

@situchan
Copy link
Contributor

This is new feature from #33665.
I think this can be fixed as follow-up by original author, not blocking deploy.
cc: @ishpaul777 @rushatgabhane

@danieldoglas
Copy link
Contributor

Thanks @situchan, and I agree.

Assigning @jasperhuangg since he was responsible for the original issue as well

@danieldoglas danieldoglas added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 15, 2024
@ishpaul777
Copy link
Contributor

I'll take a look 👀

@ishpaul777

This comment was marked as off-topic.

Copy link

melvin-bot bot commented Jan 18, 2024

@jasperhuangg Whoops! This issue is 2 days overdue. Let's get this updated quick!

@jasperhuangg
Copy link
Contributor

Contributor has opened a PR, not overdue!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 18, 2024
@jasperhuangg
Copy link
Contributor

Contributor is working on a draft PR, not overdue!

@ishpaul777
Copy link
Contributor

@jasperhuangg Can you review changes on PR or assign a c+ to review and approve changes, i have mentioned you there but comment might be missed

@jasperhuangg
Copy link
Contributor

@ishpaul777 gotcha, sorry if I missed the ping. I've pinged the C+ channel to see if there are any takers for the review

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review and removed Overdue labels Jan 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Jan 25, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

This issue has not been updated in over 15 days. @jasperhuangg eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Monthly KSv2 Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Feb 19, 2024
@melvin-bot melvin-bot bot changed the title Room - Email in Concierge message is not copied when copied to clipboard [HOLD for payment 2024-02-26] Room - Email in Concierge message is not copied when copied to clipboard Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-26. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@aimane-chnaif
Copy link
Contributor

I am eligible for payment here

@jasperhuangg jasperhuangg added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@jasperhuangg
Copy link
Contributor

@MitchExpensify Can we pay out @aimane-chnaif for PR review?

@MitchExpensify
Copy link
Contributor

@MitchExpensify Can we pay out @aimane-chnaif for PR review?

Paid and contract ended! Can we close now @jasperhuangg ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants