Login -When open public room link and sign in incorrect magic code message displayed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.25-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: create a room with tasks and copy link

1. Navigate to the public room via deeplink, e.g. https://staging.new.expensify.com/r/1898619590844985
2. Tap on any task without an assignee
3. Select Assignee
4. Enter the email of a user who has not joined the room yet
5. Enter a magic code

Expected Result:

User is returned to the task details page

Actual Result:

After tapping the "Sign in" button, the spinner is displayed briefly, but the user is still on the login page. After tapping the button the second time, the message about the incorrect magic code is displayed. When the user goes back to the room, they are logged in.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343411_1705345892035.video_2024-01-15_14-07-45.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Issue is not reproducible in production

video_2024-01-15_13-37-09.mp4

[marcochavezf]

It seems this is a regression from #33426

[marcochavezf]

Confirmed that's the offended PR and created a straight revert PR #34552

[mountiny]

CP done, asking QA to retest

[kbecciv]

@marcochavezf @mountiny Issue is no longer reproduced, build 1.4.25-7

video_2024-01-16_10-18-54.2.mp4

[mountiny]

Thanks