Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - Login - Expired magic code for a code with no prior use + inability to exit screen #34585

Closed
1 of 6 tasks
lanitochka17 opened this issue Jan 16, 2024 · 3 comments
Closed
1 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.25-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Prerequisites: User must be logged into web app as User B
1 . Launch the Desktop app

  1. Enter an email for a new account (USER A)
  2. Go to the email inbox and locate the magic code
  3. Copy the Magic link and modify it to staging
  4. On the web, open a new tab and navigate to the staging magic link
  5. Confirm that the user is prompted to open the desktop app
  6. Click on the "Open app" option
  7. Repeat steps 5,6 and 7
  8. When the apps get opened, click on ''just sign in here ''button
    ATTENTION >>>> After the first desktop launch using "Open app'' you'll need to clear browser data or open incognito mode and start the process from the prerequisites again (otherwise, the prompt to open the Desktop app will not be displayed!).

Expected Result:

The user should be able to sign in right after clicking on ''Just sign in here,'' and they should also have the option to exit the page

Actual Result:

When the desktop app is launched using the magic code deep link, the user encounters an expired magic code page even though the code is valid and has not been previously used. Additionally, it's impossible to exit that screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6344377_1705415794347.Repro_o_n_version_1.4.25-1__1.4.25-1_.mp4
Bug6344377_1705415794354.Repro_-_version_1.4.25-7.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 16, 2024

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@bondydaa bondydaa removed the DeployBlockerCash This issue or pull request should block deployment label Jan 16, 2024
@bondydaa
Copy link
Contributor

I don't think this is that important, there is probably something strange with being logged in to one account then attempting to log in with a second account which new dot is not built to handle (same for old dot for that matter). closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants