IOU - All currencies in the list are bolded

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.26-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Click FAB > Request money > Manual.
2. Click on the currency.

Expected Result:

Only the selected currency is bolded.

Actual Result:

All the currencies in the list are bolded. This issue also occurs in Theme and Language selection page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

All the currencies in the list are bolded. This issue also occurs in Theme and Language selection page.

What is the root cause of that problem?

In BaseOptionList we add boldStyle for all options

App/src/components/OptionsList/BaseOptionsList.js

Line 215 in a8acf44

boldStyle={boldStyle}

What changes do you think we should make in order to solve the problem?

bold option when it's selected

                boldStyle={isSelected  && boldStyle}

What alternative solutions did you explore? (Optional)

NA

[dummy-1111]

This is a regression of this PR #34357

[situchan]

cc: @s77rt

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

All the currencies in the list are bolded. This issue also occurs in Theme and Language selection page.

What is the root cause of that problem?

We added the bold style for all item of selection list

App/src/components/SelectionList/BaseListItem.js

Line 108 in a8acf44

styles.sidebarLinkTextBold,

What changes do you think we should make in order to solve the problem?

We should update to only apply bold style for selected option

App/src/components/SelectionList/BaseListItem.js

Line 108 in a8acf44

styles.sidebarLinkTextBold,

item.isSelected && styles.sidebarLinkTextBold

What alternative solutions did you explore? (Optional)

NA

[s77rt]

Not a bug. This is done on purpose

[s77rt]

cc @shawnborton for confirming in case I missed something here.

[shawnborton]

Correct, this is intended behavior. cc @Expensify/design

Closing!

[amyevans]

Thanks for confirming!