[HOLD for payment 2024-02-07] Focus mode modal can show incorrectly when signing up for a new account after logging out of an existing account.

[marcaaron]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Signed up for expensify.com using a gmail account
2. Get directed to new.expensify.com (good ✅ )

Expected Result:

We should only show this modal for users who have more than 30 chats.

Actual Result:

Saw [the focus mode] modal first (bad ❌)
This was a brand new account and I had only one chat.

Workaround:

👍

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014e891ac070cbe788
• Upwork Job ID: 1748181663725543424
• Last Price Increase: 2024-01-19

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014e891ac070cbe788

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[sophiepintoraetz]

I'm guessing I'm here for the C+ payment of the review?

[marcaaron]

Yes. I've got a PR in the works already.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add filtering to the reports data in the Focus mode switch logic #34624

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

@c3024 reviewed the associated PR.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: Update users to focus mode automatically if they have the minimum report number #30664
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: The present fix is made by the same PR author so not commented.
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not started because this could not have been caught earlier.
• [@c3024] Determine if we should create a regression test for this bug. Yes
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Tests here are suitable regression tests.

Tests

Verify focus mode switch still works and there are no regressions

1. Ensure signed out of both OldDot and NewDot
2. Sign into a NewDot account that has 30+ chats (must be a new account)
3. Verify the focus mode alert still works correctly

Verify focus mode modal is not incorrectly showed for brand new account after signing out of large account

1. Ensure signed out of both OldDot and NewDot
2. Sign into an account that has many hundreds of chats in NewDot
3. Sign out
4. Create new account on a public domain in OldDot
5. Verify you are redirected to NewDot
6. Verify the Focus mode modal does not show incorrectly

👍 or 👎

[melvin-bot]

@marcaaron, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Regression steps look good, proposed they be added in https://github.com/Expensify/Expensify/issues/366901.

Payment due on Wednesday.

[bfitzexpensify]

Payment summary:

C+: @c3024 to be paid $500 via manual request.

[bfitzexpensify]

We're all done here, closing this one out.

[c3024]

I'm not eligible for manual requests yet. I can only be paid on Upwork. @bfitzexpensify

[bfitzexpensify]

Gotcha - I've just made the Upwork job public, can you apply to it and let me know when you've done so?

[c3024]

Thanks. Applied. Here is my Upwork profile as well for reference just in case if someone else has also applied.

https://www.upwork.com/freelancers/~0105555e2f227dbf47

[bfitzexpensify]

Thanks, all paid out - now we're done