[HOLD for payment 2024-01-31] [Wave6] When changing the amount from 0 to something, the modified expense message is not correct

[mountiny]

Problem

Coming from here, when smartscanning a receipt the amount is set to 0. When you change the amount during smartscanning the modified expense message incorrectly says previously $0.00

Solution

Make sure when the previous amouont was 0 we do not show the previously part

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015737b2ce48ba507d
• Upwork Job ID: 1749586053768220672
• Last Price Increase: 2024-01-23

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015737b2ce48ba507d

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[mountiny]

simple change, PR is up, no need for C+ this time

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [wave6] Polish the modified expense message when changing from partial amount #34939

If no regressions arise, payment will be issued on 2024-01-31. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: