[Report Fields] Update 'deletable' fields to show as "remove field " vs. "empty"

[caitlinwhite1]

The current funtionailty for Report Fields allows the user to set a value as "empty" to delete the field. We'll want to update the UI so it's more apparent to the end user. More contect in this thread,

If a report field exists within a report but has been removed from the policy, mark the report field as 'deletable' by showing "Remove field" in the overflow menu for each individual report field that becomes deletable. For Example:

• If a field is called Department, then we’d show RBR next to the right caret for that field(just like shown in the details section in the below mock-up)
• Then when you tap on that row for the report field and we push-to-page, you see the red error message below the field input.

[allroundexperts]

@caitlinwhite1 Can I please get a UI screen of how this x would look like? Thanks!

[caitlinwhite1]

@allroundexperts Yup! Let me grab something from Figma

[caitlinwhite1]

@allroundexperts I updated with the context from that slack thread but let me know if you need any other info!

[allroundexperts]

Thanks @caitlinwhite1. I was waiting for my other PR related to backend integration to get merged first. It got in Yesterday so I should be making a PR for this soon!

[allroundexperts]

Update: Created a draft PR here. Waiting on @thienlnam to provide me with the API endpoint needed to delete the report field.

[allroundexperts]

Hi @thienlnam!
Did you get a chance to create the endpoint needed to delete the report field?

[thienlnam]

Yup, it's merged pending deploy - should be available on staging tomorrow. Here are those details

Endpoint: RemoveReportField
Parameters:

• fieldID: field_id_21312

[allroundexperts]

Still getting the following:

How do I set the server as staging in the App? I no longer see that option in preferences.

[thienlnam]

Not sure, but it's on production now so you should be able to test there.

Also as a note - due to the way these are stored, you'll have to prefix the fieldID with expensify_

So same as the changes I made here #36769

[JmillsExpensify]

@allroundexperts quick note that we are trying to wrap up the report fields initiative by the end of this month. Do you think it'll be possible to get this PR merged by then?

[allroundexperts]

@JmillsExpensify This is blocked on #36170 which is waiting changes from the backend. I'm not sure how long it will take for those changes to get in. This can not be completed until those are done.

[JmillsExpensify]

Nice, appreciate the color. I'm also going to go ahead and move this to our Polish section on a second read of the description. Ideally we can still get this merged before the end of the month!

[JmillsExpensify]

Circling back on this one, with the PR for #36170 now merged, are we good to pick this one back up?

[allroundexperts]

Yes. I'll try to resolve the conflicts today and make it ready for review.

[jjcoffee]

Hit production 2024-04-10, payment should be due tomorrow. cc @JmillsExpensify

[melvin-bot]

This issue has not been updated in over 15 days. @allroundexperts, @thienlnam eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[caitlinwhite1]

This deployed so i think we're all set to close!

#36039 (comment)

[jjcoffee]

@caitlinwhite1 Please can you reopen as payment is due for the PR review? Thanks 🙏

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[caitlinwhite1]

@dylanexpensify reopening and adding bug label for payrment!

[dylanexpensify]

Nice one!

Payment summary:

• Contributor+: @jjcoffee $500
• Contributor: @allroundexperts $500

Please apply or request!

[jjcoffee]

Thanks, applied @dylanexpensify!

[allroundexperts]

@dylanexpensify Can you write up my summary as well? 😄

[dylanexpensify]

Yes!

[dylanexpensify]

@jjcoffee sent offer! Also @allroundexperts updated original post btw!

[jjcoffee]

@dylanexpensify Accepted, cheers!

[dylanexpensify]

Paid @jjcoffee!

[JmillsExpensify]

$500 approved for @allroundexperts