Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After logging in, chat is displayed instead of LHN #3537

Closed
kavimuru opened this issue Jun 11, 2021 · 6 comments · Fixed by #3552
Closed

After logging in, chat is displayed instead of LHN #3537

kavimuru opened this issue Jun 11, 2021 · 6 comments · Fixed by #3552
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Jun 11, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

After logging in, user is taken to the LHN

Actual Result:

After logging in, user is taken to a random chat

Action Performed:

  1. Launch the app
  2. Log in with any account

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS✔️
Android✔️
Desktop App
Mobile Web

Version Number: 1.0.67-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5107438_Screen_Recording_20210610-185507_Expensifycash.mp4

Expensify/Expensify Issue URL:

view this job on upwork

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@flodnv flodnv removed their assignment Jun 11, 2021
@flodnv flodnv added the External Added to denote the issue can be worked on by a contributor label Jun 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@jboniface jboniface changed the title Android - After logging in, chat is displayed instead of LHN After logging in, chat is displayed instead of LHN Jun 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@parasharrajat
Copy link
Member

parasharrajat commented Jun 11, 2021

I would like to fix this @NikkiWines

Proposal

  1. we have updated the react-navigation lib to v6 which does not have openByDefault prop. So to fix this, we need to add a defaultStatus as
<Drawer.Navigator
            defaultStatus={props.isSmallScreenWidth ? 'open' : 'closed'}

instead of https://github.com/Expensify/Expensify.cash/blob/3284a15cb0bef712dc44828905e26943ed5491f8/src/libs/Navigation/AppNavigator/MainDrawerNavigator.js#L54

@NikkiWines
Copy link
Contributor

That looks good, confirmed on the docs that openByDefault is no longer used. @jboniface you're good to hire @parasharrajat for this one

@isagoico
Copy link

Issue reproducible today during KI retests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants