[$250] MEDIUM: Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list

[waterim]

Problem:

Right now there are no possibilities to add anyone to the automatically created workspace chats, but it should be possible to add by "mention"; it's similarly not possible to remove someone who has been thus added.

Solution:

As discussed here, we would like to add this possibility to:

1. Allow anyone to be added to the workspace chat via @mention
2. Allow anyone to be added to the workspace chat via the Invite button of the members page
3. Allow anybody who wasn't auto-added (ie, admins or the employee) to be removed via the members page

IMPORTANT details for workspace chats:

• To understand more regarding automatically added users read this [$500] HIGH: Review who can remove whom from groups, workspaces, and workspace objects #33575 (comment)
• What we want to achieve: [$500] HIGH: Review who can remove whom from groups, workspaces, and workspace objects #33575 (comment)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013623b6c6ce0881ae
• Upwork Job ID: 1753488042510364672
• Last Price Increase: 2024-06-28
• Automatic offers:
• brunovjk | Contributor | 0

Issue Owner

Current Issue Owner: @johncschuster

[quinthar]

optimistically assigning to @waterim

[waterim]

@quinthar Yes, I can take this one
Im still OOO(sick leave) today and can work in this one from Monday.

[jasperhuangg]

This has to be fixed internally, I can take this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013623b6c6ce0881ae

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[jasperhuangg]

Won't need C+ reviews for these PRs, at least for now

[quinthar]

What's the next step here? Who is doing it and when?

[jasperhuangg]

@quinthar sorry, been bogged down with Wave work. The next step is to update the Auth checks that dictate who can be invited to a workspace chat. We can then update the front-end to handle the changes involving allowing only the people who weren't automatically added to be removed.

One of my wave issues was deprioritized, so I can get cracking with this tomorrow!

[jasperhuangg]

First thing I noticed is that policy expense chats don't give the user/approvers "read, write, share" permissions by default, so I'm going to open a PR to fix that since those permissions are needed in order to invite to the report.

[jasperhuangg]

Just a quick update on this, I have a PR up and I'm figuring out some MergeAccount tests that it broke.

[jasperhuangg]

Gonna continue pushing this PR forward today.

[jasperhuangg]

Quick update, Auth PR is on HOLD for the Web-E^ to go out to production. It's on staging right now

[jasperhuangg]

Gonna continue pushing this forward today. Had to deprioritize it for other items.

[brunovjk]

Update: PR being reviewed

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent removal of admin and default members from workspace chats #43065

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @brunovjk requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[johncschuster]

Acknowledged! I'll issue payment on the 24th!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent removal of admin and default members from workspace chats #43065

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @brunovjk requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[brunovjk]

Acknowledged! I'll issue payment on the 24th!

@johncschuster Could we get an increase in the bounty here? Mainly to cover regression. Extensive testing and adjustments were necessary during and after the PR was merged. Thank you 🙏

cc: @jasperhuangg

[johncschuster]

@brunovjk Let me check in with the team about your request. I'll follow up in a bit!

[brunovjk]

Thank you :D

[johncschuster]

@brunovjk, I chatted with the team, and it seems like a regression was introduced here, which would result in a payment reduction, not an increase. Can you tell me a bit more about why you feel there should be an increase?

[brunovjk]

Thank you @johncschuster. Here's an explanation:

The initial task here was Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list PR, then we had to update "who can" select/add/remove and which users can be selected/removed on workspace chats PR. That's why I asked for an increase in the reward, since this second PR involved a lot of testing and two regressions, #43828 and #42928 .
My idea was for the bounty to be $1000, minus the two regressions totalizing $250. But, I am in favor of any of your decisions.

@jasperhuangg do we need to wait for #42928 to proceed with payment here?

[johncschuster]

Payment Summary:

Contributor: @brunovjk - $1000 $250 (reduced for 2x regressions) - paid via Upwork - PAID
Contributor+: @mananjadhav - $1000 $250 (reduced for 2x regressions) - requires payment through NewDot Manual Requests

[melvin-bot]

Upwork job price has been updated to $250

[johncschuster]

@mananjadhav, can you propose a regression test checklist?

[mananjadhav]

@johncschuster I think the test steps from the PR here. I are good for the checklist. Can we please use that?

Pre-condition:

1. We need 4 accounts for this test:

• Workspace Creator
• Workspace Admin
• Workspace Member
• No-workspace member (invited)

2. Login in the app as "Workspace Creator"
3. Create a workspace
4. Go to the automatically created "Workspace Chat"
5. Go to the "Report Details"
6. Go to "Members" page Click "Invite"
7. Invite all the other 3 accounts (admin, member, and invited) to the "Workspace Chat"
8. Still on the "Members" page, change the admin role to Administrator 8. Click on the "Global Fab" "Start Chat" Select "#Room" tab
9. Create a "workspace-room"
10. Invite all the other 3 accounts (admin, member, and invited) to the "workspace-room"

Tests:

1. Logged as the "Workspace Creator":

i. Go to the "Workspace Chat" Report Details page
ii. Verify that the "Leave" button doesn't show, as you are a "workspace admin".
iii. Go to "Members" page
iv. Verify that you cannot select/remove admin and default added members
v. Verify that you can "Invite" and "Remove" (admin cannot be removed) members
vi. Go to the "workspace-room" Report Details page
vii. Go to "Members" page
viii. Verify that you can "Invite" and "Remove" (you cannot remove yourself here) members

2. Logged as the "Workspace Admin":

i. Go to the "Workspace Chat" Report Details page
ii. Verify that the "Leave" button doesn't show, as you are a "workspace admin".
iii. Go to "Members" page
iv. Verify that you cannot select/remove admin and default added members
v. Verify that you can "Invite" and "Remove" (admin cannot be removed) members
vi. Go to the "workspace-room" Report Details page
vii. Go to "Members" page
viii. Verify that you can "Invite" and "Remove" (you cannot remove yourself here) members

3. Logged as the "Workspace Member":

i. Go to the "Workspace Chat" Report Details page
ii. Verify that the "Invite" button does not show.
iii. Go to "Members" page
iv. Verify that you cannot "Invite" and "Remove" members.
v. Logged as the "Workspace Member" Go to the "workspace-room" Report Details page
vi. Verify that the "Invite" button does not show.
vii. Go to "Members" page
viii. Verify that you can "Invite" and "Remove" (you cannot remove yourself here) members.

4. Logged as the "Workspace Chat Invited":

i. Go to the "Workspace Chat" Report Details page
ii. Verify that the "Invite" button does not show.
iii. Go to "Members" page
iv. Verify that you cannot "Invite" and "Remove" members.
v. Logged as the "Workspace Room Invited" Go to the "workspace-room" Report Details page
vi. Verify that the "Invite" button does show and you can invite members to the chat.

[JmillsExpensify]

$250 approved for @mananjadhav