Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags - Numbers are not alphabetically ordered #35421

Closed
3 of 6 tasks
lanitochka17 opened this issue Jan 30, 2024 · 3 comments
Closed
3 of 6 tasks

Tags - Numbers are not alphabetically ordered #35421

lanitochka17 opened this issue Jan 30, 2024 · 3 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.33-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4252172
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must have created a collect workspace

  1. As the admin on OD, add some tags named "Tag 1", "Tag 2", "Tag 3", "Tag 10"
  2. On ND, go to workspace chat
  3. Create a manual money request, enter the amount
  4. Tap on "Show more"
  5. Tap on the tag field

Expected Result:

The tags should be ordered alphabetically, from 1 to 10

Actual Result:

The tags are not correctly ordered, the number 10 follows the number 1

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6361136_1706635329507!IMG_E2714

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Jan 30, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 30, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 30, 2024

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@francoisl
Copy link
Contributor

I'm seeing the same sorting logic on production

image

and also on OldDot

image

This is because we sort tags like plain strings (we don't take numbers into account), which is fine.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants