Tapping on Edit Message scrolls down to the bottom to the compose box

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

Describe what you think should've happened

Expected result:

User stays in the same position and is able to edit the message

Actual result:

Tapping on Edit scrolls down the page to the compose box

Actions Performed:

1. Launch the app and log in
2. Hover over a sent message and click on the edit comment option in the menu
3. Start editing the message

Platform:

Android ✔️

Notes/Images/Video:

Bug5107427_Screen_Recording_20210610-190557_Expensifycash.mp4

Version Number: 1.0.67-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[isagoico]

Added the deploy blocker label. We didn't experience this issue on last regression.

[Julesssss]

Hey @isabelastisser, do you know if is this Android only or also occurring on iOS?

[trjExpensify]

I can reproduce this on iOS v1.0.67-0.

Image.from.iOS.3.MP4

[francoisl]

In a 1:1 right now, but I can take a look a bit later, otherwise anyone feel free to start digging and I'm happy to help later too.

[parasharrajat]

@Julesssss
Can I propose a fix here?

The issue is this line https://github.com/Expensify/Expensify.cash/blob/3284a15cb0bef712dc44828905e26943ed5491f8/src/pages/home/report/ReportActionsView.js#L110.

But this is necessary. So we should add a check in the event listener that when the main ReportActionComposer is focused only then scrolltoBottom.

But now the question is how we will get the focused state of composer here? I don't like nested forwarding the refs. so as per my PR, we are already implementing the ReportActionComposerFocusManager. We can extend the same lib to have a function
isFocused tells us about the focused state of the Composer. Now we can use it here https://github.com/Expensify/Expensify.cash/blob/3284a15cb0bef712dc44828905e26943ed5491f8/src/pages/home/report/ReportActionsView.js#L110.
and conditionally scroll to the bottom.

Implementation of isFocused.

const composerRef = React.createRef();
function isFocsued(){
   if(composerRef.current){
     composerRef.current.isFocused();
   }
}

we can then set composerRef in ReportActionComposer.

[Julesssss]

That sounds great to me @parasharrajat. Thanks for taking a look!

We'll also remove the deployBlocker here as it's not critical enough to block our release. Let's get an UpWork issue created for you too.

[MelvinBot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

No worries, But is PR is up here #3551. Thanks

[isagoico]

Issue reproducible today during KI retests

[MitchExpensify]

Job created here and have invited you @parasharrajat !