Expense - LHN preview for request report shows owner name next to request edit system message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.34-0
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: User is an employee of Collect workspace on Old Dot.

1. Create a distance request in the workspace chat.
2. Go to distance request details page.
3. Go offline.
4. Click Description.
5. Edit the description and save it.
6. Note that the LHN preview shows the owner name.
7. Go online.

Expected Result:

In Step 6, LHN preview for the expense details report will not show the owner name (current user) next to the system message.

Actual Result:

In Step 6, LHN preview for the expense details report shows the owner name next to the system message.
The owner name disappears after returning online in Step 7.
The issue is reproducible without going online. In that case, the owner name appears and disappears quickly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362826_1706731589781.bandicam_2024-02-01_01-35-17-104.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @blimpich (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave6-collect-submitters
CC @dylanexpensify

[blimpich]

This isn't a blocker, too niche, should be solved though.

[blimpich]

Looks like #34872 might be PR that caused this? @koko57 could you take a look and confirm or deny?

[koko57]

@blimpich not sure if this one or the previous one I was working on a while ago. I'm still working on LHN previews follow-ups - I can fix this issue while working on the next PR 🙂

[blimpich]

@koko57 sounds good, thank you! Is there already an issue and reviewer for that next PR or do you think I should mark this as external, get a C+ reviewer for it, and assign you to this issue? I'm fine either way.

[koko57]

@blimpich I can do this as a part of LHN follow-ups issue

cc @mountiny

[mountiny]

We can handle it there or here @blimpich whatever you prefer, I can copy over this issue to the list in that linked PR. What do you think?

[blimpich]

@mountiny copying it over to the linked PR sounds perfect to me, thank you both!

[mountiny]

Added, thanks!