[HOLD for payment 2024-02-15] [$500] Wallet - Back button loops the app between Expensify card and Activate card after page refresh

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #35303

Action Performed:

1. Log in with account that has Expensify card (virtual) (applausetester@applause.expensifail.com
   )
2. Go to Settings > Wallet
3. Click Expensify card
4. Click Activate physical card
5. Refresh the page
6. Click on the back button
7. Click on the back button again

Expected Result:

Back button will navigate to the previous page

Actual Result:

Back button loops the app between Expensify card and Activate card page after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362463_1706714036406.20240131_222312.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010098f2976f28fbf7
• Upwork Job ID: 1752867434380029952
• Last Price Increase: 2024-02-01
• Automatic offers:
• fedirjh | Reviewer | 28133789
• Ollyws | Contributor | 28133791
• dukenv0307 | Contributor | 28135667

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010098f2976f28fbf7

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[lanitochka17]

We think that this bug might be related to #wave5.
CC @dylanexpensify

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button loops the app between Expensify card and Activate card page after refreshing the page

What is the root cause of that problem?

In here, we're using navigate, not goBack will a fallback, so the current page (ActivatePhysicalCardPage) is not popped from the stack, when go back in the ExpensifyCardPage, since the page behind it in the stack is still the ActivatePhysicalCardPage, so it go to the ActivatePhysicalCardPage again, and it will loop like that forever.

What changes do you think we should make in order to solve the problem?

In here, use goBack instead of navigate

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET_DOMAINCARD.getRoute(domain))}

What alternative solutions did you explore? (Optional)

We should double check other pages in the physical card flow and fix similarly if it happens elsewhere on another page.

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jliexpensify]

@Ollyws @luacmartins

Issue found when executing PR #35303

Is this a regression?

[dukenv0307]

Is this a regression?

@jliexpensify no it's not, it was reproducible before that PR

[Ollyws]

Given it's not a regression from ours does the originally auto-assigned C+ @fedirjh want to take this?
I feel like I'd be eating their lunch a bit given how simple it is. 😅

[luacmartins]

That sounds good to me, reassigning @fedirjh. Thanks @Ollyws!

[luacmartins]

I think @dukenv0307's proposal looks good. What do you think @fedirjh?

[fedirjh]

@luacmartins I agree with you. The proposal looks good to me, let's proceed with it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@luacmartins, @jliexpensify, @fedirjh, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

Awaiting PR from @dukenv0307

[dukenv0307]

@fedirjh The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix back loop between expensify card and active card page #35867

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Bump @fedirjh to complete the checklist

[fedirjh]

BugZero Checklist:

• Link to the PR: activate physical card #28313
• Link to comment: activate physical card #28313 (comment)
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: Y

1. Log in with account that has Expensify card (virtual)
2. Go to Settings > Wallet
3. Click on a Expensify card
4. Click on Activate physical card
5. Refresh the page
6. Click on back button twice
7. Verify that we go back to wallet page

[jliexpensify]

Paid and job closed!