-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-04-05] [$500] [Simplified Collect][Members] Changing owner: Full flow implementation #35716
Comments
Triggered auto assignment to @CortneyOfstad ( |
@burczu can you please comment here so I can assign you to the issue? |
Hi! I'm Bartek from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you. |
@burczu, @CortneyOfstad, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@burczu any updates here? Thanks! |
Job added to Upwork: https://www.upwork.com/jobs/~01289ff00d54fea22e |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Triggered auto assignment to @CherylWalsh ( |
@CherylWalsh we currently have the modal below in OldDot. This modal is displayed when a user is trying to transfer the ownership of a workspace to themselves, but there's an unknown error clearing the owed balance. Could you please check if we want to keep the same working in NewDot? |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-04-05. 🎊 For reference, here are some details about the assignees on this issue: |
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@mollfpr — can you update the checklist before EOD tomorrow if a regression test is needed? Thanks! |
Sorry for the delay! @CortneyOfstad It's a new flow, so we need a regression test. Also, I'm not fully test the PR.
|
No need to add tests here. We're adding it as part of the project - https://github.com/Expensify/Expensify/issues/383378 |
Payment Summary@mollfpr to be paid $500 via NewDot |
$500 approved for @mollfpr |
Implement
Changing owner: Full flow implementation
from the Simplified Collect: Profile, Members, Categories design docIssue Owner
Current Issue Owner: @burczuUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: