Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-05] [$500] [Simplified Collect][Members] Changing owner: Full flow implementation #35716

Closed
luacmartins opened this issue Feb 2, 2024 · 47 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2024

Implement Changing owner: Full flow implementation from the Simplified Collect: Profile, Members, Categories design doc

Issue OwnerCurrent Issue Owner: @burczu
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01289ff00d54fea22e
  • Upwork Job ID: 1755658801369747456
  • Last Price Increase: 2024-02-08
Copy link

melvin-bot bot commented Feb 2, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2024
@luacmartins
Copy link
Contributor Author

@burczu can you please comment here so I can assign you to the issue?

@luacmartins luacmartins moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 2, 2024
@luacmartins luacmartins added Daily KSv2 and removed Daily KSv2 Weekly KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title [Simplified Collect] [Members] Changing owner: Full flow implementation [Simplified Collect][Members] Changing owner: Full flow implementation Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@burczu
Copy link
Contributor

burczu commented Feb 5, 2024

Hi! I'm Bartek from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you.

Copy link

melvin-bot bot commented Feb 8, 2024

@burczu, @CortneyOfstad, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@CortneyOfstad
Copy link
Contributor

@burczu any updates here? Thanks!

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 8, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Members] Changing owner: Full flow implementation [$500] [Simplified Collect][Members] Changing owner: Full flow implementation Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01289ff00d54fea22e

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@luacmartins luacmartins added the Waiting for copy User facing verbiage needs polishing label Mar 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 20, 2024
Copy link

melvin-bot bot commented Mar 20, 2024

Triggered auto assignment to @CherylWalsh (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Weekly KSv2 labels Mar 20, 2024
@luacmartins
Copy link
Contributor Author

@CherylWalsh we currently have the modal below in OldDot. This modal is displayed when a user is trying to transfer the ownership of a workspace to themselves, but there's an unknown error clearing the owed balance. Could you please check if we want to keep the same working in NewDot?

Screenshot 2024-03-20 at 10 08 30 AM

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 21, 2024
Copy link

melvin-bot bot commented Mar 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Simplified Collect][Members] Changing owner: Full flow implementation [HOLD for payment 2024-04-05] [$500] [Simplified Collect][Members] Changing owner: Full flow implementation Mar 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @burczu does not require payment (Contractor)
  • @mollfpr requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@CortneyOfstad / @adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@CortneyOfstad
Copy link
Contributor

@mollfpr — can you update the checklist before EOD tomorrow if a regression test is needed? Thanks!

@mollfpr
Copy link
Contributor

mollfpr commented Apr 3, 2024

Sorry for the delay!

@CortneyOfstad It's a new flow, so we need a regression test. Also, I'm not fully test the PR.

  1. Log in to the App as an admin of the paid workspace who is not an owner at the same time
  2. Open paid workspace
  3. Go to the Members page
  4. Click on the owner of the workspace
  5. Click "Transfer owner"
  6. Follow instructions and check if everything works correctly

@luacmartins
Copy link
Contributor Author

No need to add tests here. We're adding it as part of the project - https://github.com/Expensify/Expensify/issues/383378

@CortneyOfstad
Copy link
Contributor

Payment Summary

@mollfpr to be paid $500 via NewDot

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 5, 2024
@JmillsExpensify
Copy link

$500 approved for @mollfpr

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Waiting for copy User facing verbiage needs polishing Weekly KSv2
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

8 participants