[$500] [HOLD for payment 2024-02-14] mweb - Compose - Tapping emoji picker, keypad pops up on emoji box page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.5.36.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4279600
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Tap emoji picker from compose box

Expected Result:

When user taps emoji picker, keypad must not pop up on emoji box page

Actual Result:

When user taps emoji picker, keypad pops up on emoji box page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365232_1706901898987.az_recorder_20240203_004927.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad9a549f2e03c9fe
• Upwork Job ID: 1757788628485996544
• Last Price Increase: 2024-02-14

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[aldo-expensify]

Reproduced in staging and can't reproduce in production

Screenrecorder-2024-02-02-12-54-23-788.mp4

[aldo-expensify]

Sorry, got distracted with other issues. I think the keyboard appears immediately because the "Search" field gets automatically focused. I don't see that auto-focus in production.

[francoisl]

This might not be worth being a blocker, but yes ideally we'd stay consistent with other platforms and not show the keyboard.

[francoisl]

Could be a red herring but this PR from the checklist modified the EmojiPicker #34581

[aldo-expensify]

Could be a red herring but this PR from the checklist modified the EmojiPicker #34581

I noticed this PR, but it doesn't appear to be in staging yet, or at least the comment of deployment to staging is missing

[aldo-expensify]

Seems like I'm wrong and the #34581 is already merged in version v1.4.36-0 unless I'm looking at the wrong things

[aldo-expensify]

tested a revert of the PR #35737 and it does fix the deploy blocker

[francoisl]

Hm yeah there was supposed to be a comment in the PR saying that it was deployed to staging, looks like a bug :(
I checked the 1.4.36-0 tag locally and the code from that PR is definitely on it, so yes it's deployed to staging at the moment.

[aldo-expensify]

Thanks @francoisl for the help, and yess, the missing comment mislead me, I won't trust that anymore :P

[francoisl]

Sounds good, feel free to send the PR my way and we can CP it.

[aldo-expensify]

Sounds good, feel free to send the PR my way and we can CP it.

In case they prefer to do some easy/quick fix rather than reverting, I was going to wait till Monday since we are not deploying today anyways. What do you think?

[francoisl]

Good idea, at least we'll have the revert as an option on Monday if it's still blocking the deploy.

[TMisiukiewicz]

Working on a fix

[mountiny]

Demoting this from a deploy blocker, I see a fix has been raised but I dont think we have to CP

[roryabraham]

PR merged, but per @mountiny's comment I'm not going to request CP. Sorry we missed this in the previous PR, and thanks @aldo-expensify for giving @TMisiukiewicz some time to fix this, good call 👍🏼

[mountiny]

Yeah I think this is minor, but if anyone feels like CPing not against it

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Focusing emoji search input on mWeb #35796

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @TMisiukiewicz does not require payment (Contractor)
• @jjcoffee requires payment (Needs manual offer from BZ)

[jjcoffee]

No payment required here as it was a regression fix!

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @alexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @TMisiukiewicz is from an agency-contributor and not due payment
• ROLE: @jjcoffee paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad9a549f2e03c9fe

[melvin-bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[alexpensify]

@jjcoffee - another one to accept, thanks!

https://www.upwork.com/jobs/~01ad9a549f2e03c9fe

[jjcoffee]

@alexpensify Ah sorry, I think no payment is due on this one as it was just a minor regression fix!

[alexpensify]

@jjcoffee thanks for flagging, let me review and I'll reply tomorrow with an update.

[alexpensify]

Ok, I've closed the job in Upwork but still left positive feedback. Thanks again for your help and flagging the payment breakdown here.