Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in the composer is very small when device font size is minimum #35787

Closed
2 of 6 tasks
lanitochka17 opened this issue Feb 4, 2024 · 13 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: Device font size is set to minimum

  1. Launch New Expensify app
  2. Open any chat
  3. Type in the composer
  4. Send it

Expected Result:

The text in the composer has the same size as the text in the chat
image

Actual Result:

The text in the composer is smaller than the text in the chat
image

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6366898_1707065880365!Screenshot_2024-02-05_at_00 55 51
Bug6366898_1707065880367.Screen_Recording_20240203_033427_New_Expensify.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 4, 2024
Copy link
Contributor

github-actions bot commented Feb 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 4, 2024

Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Feb 5, 2024

Not a blocker. @lanitochka17 how does this behave in production?

@kavimuru
Copy link

kavimuru commented Feb 5, 2024

@mountiny this is the video from production

Screen_Recording_20240203_033512_Settings.mp4

@mountiny
Copy link
Contributor

mountiny commented Feb 5, 2024

cc @tomekzaw @thienlnam this might be related to the live markdown feature

@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2024
@thienlnam
Copy link
Contributor

Looks like this is applicable to iOS as well https://expensify.slack.com/archives/C049HHMV9SM/p1707328995049399

I'll go ahead and take this over

@thienlnam thienlnam assigned thienlnam and unassigned grgia Feb 7, 2024
@melvin-bot melvin-bot bot removed Overdue labels Feb 7, 2024
@thienlnam thienlnam changed the title Android - Text in the composer is very small when device font size is minimum Text in the composer is very small when device font size is minimum Feb 7, 2024
@thienlnam
Copy link
Contributor

thienlnam commented Feb 7, 2024

@tomekzaw Are we able to scale back the font size from the setting a bit? It seems to be much smaller than iMessage

Here's iOS at the smallest font size from @AndrewGable
image
image

@tomekzaw
Copy link
Contributor

tomekzaw commented Feb 7, 2024

Thanks for reporting this issue. I think we use original fontSize passed via styles but obviously this needs investigation since it changes the behavior of the composer.

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
@tomekzaw
Copy link
Contributor

Should be fixed with #35973.

The root cause of the issue was missing allowFontScaling={false} property.

Expensify app uses its own logic for font scaling so it disables operating system scaling.

Previously, composer would use RNTextInput which is a thin wrapper over built-in TextInput but with allowFontScaling={false} and some other properties already set.

In #34292, I replaced RNTextInput with MarkdownTextInput directly without any wrappers so allowFontScaling={false} property is not set. PR #35973 restores the wrapper.

cc @thienlnam

@thienlnam
Copy link
Contributor

PR in review

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

@tomekzaw, @thienlnam, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

@tomekzaw
Copy link
Contributor

Fixed in #35973.

@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants