-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-26] [New architecture] Upgrade react-native-image-picker
#35994
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This is just updating an existing dependency, right? If so, then I don't need to go through the above workflow. It would be useful to know what the current version is and what version it's being upgraded to. @j-piasecki is that something you can add, please? |
Yep, there were a number of plain upgrades that were given the |
This comment was marked as outdated.
This comment was marked as outdated.
@slafortune this task is just forked off of a larger task to enable the new react native architecture in E/App. So no action is needed from you at this time, SWM will handle it. Thanks! |
Hey! I'm Bartosz from Software Mansion and I would like to work on this task. |
Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Triggered auto assignment to @abekkala ( |
Payment for @DylanDylann as a C+ who reviewed the PR after the regression period is over |
thanks @hayata-suenaga Is this a $250 PR review payment or $500? |
|
We didn't specify a reduced bounty for this or related issues, so I think it would be the standard $500 |
@DylanDylann I sent an offer here. I see that the PR: #36158 has not merged to production yet. |
react-native-image-picker
react-native-image-picker
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-26. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
PAYMENT SUMMARY FOR FEB 26Fix: @BartoszGrajdek does not require payment |
Payment Summary
BugZero Checklist (@abekkala)
|
@DylanDylann payment sent and contract ended - thank you! 🎉 |
We need to upgrade
react-native-image-picker
in order to use the new architecture in the App.More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293489023209
Current version: 5.1.0
Target version: 7.0.3+
The text was updated successfully, but these errors were encountered: