Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-26] [New architecture] Upgrade react-native-image-picker #35994

Closed
j-piasecki opened this issue Feb 7, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@j-piasecki
Copy link
Contributor

j-piasecki commented Feb 7, 2024

We need to upgrade react-native-image-picker in order to use the new architecture in the App.

More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293489023209

Current version: 5.1.0
Target version: 7.0.3+

@j-piasecki j-piasecki added AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2 labels Feb 7, 2024

This comment was marked as outdated.

This comment was marked as resolved.

@tgolen
Copy link
Contributor

tgolen commented Feb 7, 2024

This is just updating an existing dependency, right? If so, then I don't need to go through the above workflow. It would be useful to know what the current version is and what version it's being upgraded to. @j-piasecki is that something you can add, please?

@roryabraham
Copy link
Contributor

Yep, there were a number of plain upgrades that were given the AutoAssignerAppLibraryReview label by mistake. Going to recategorize this one like I did the others.

@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App labels Feb 7, 2024
@roryabraham roryabraham assigned j-piasecki and unassigned tgolen Feb 7, 2024

This comment was marked as outdated.

@roryabraham
Copy link
Contributor

roryabraham commented Feb 7, 2024

@slafortune this task is just forked off of a larger task to enable the new react native architecture in E/App. So no action is needed from you at this time, SWM will handle it. Thanks!

@BartoszGrajdek
Copy link
Contributor

Hey! I'm Bartosz from Software Mansion and I would like to work on this task.

Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hayata-suenaga hayata-suenaga added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 14, 2024
@hayata-suenaga
Copy link
Contributor

Payment for @DylanDylann as a C+ who reviewed the PR after the regression period is over
PR was made by an expert agency engineer

@abekkala
Copy link
Contributor

thanks @hayata-suenaga

Is this a $250 PR review payment or $500?

@roryabraham roryabraham removed the Bug Something is broken. Auto assigns a BugZero manager. label Feb 15, 2024
@hayata-suenaga
Copy link
Contributor

Is this a $250 PR review payment or $500?
confirming with Rory

@roryabraham
Copy link
Contributor

We didn't specify a reduced bounty for this or related issues, so I think it would be the standard $500

@abekkala
Copy link
Contributor

@DylanDylann I sent an offer here.

I see that the PR: #36158 has not merged to production yet.
Once it's merged to production and the regression waiting is over, I'll initiate payment

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Feb 19, 2024
@melvin-bot melvin-bot bot changed the title [New architecture] Upgrade react-native-image-picker [HOLD for payment 2024-02-26] [New architecture] Upgrade react-native-image-picker Feb 19, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@abekkala
Copy link
Contributor

PAYMENT SUMMARY FOR FEB 26

Fix: @BartoszGrajdek does not require payment
PR Review: @DylanDylann Offer

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Payment Summary

Upwork Job

BugZero Checklist (@abekkala)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@abekkala
Copy link
Contributor

@DylanDylann payment sent and contract ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

8 participants