[HOLD for payment 2024-03-18] [$500] Add edit system messages for tasks

[thienlnam]

When you edit a task, there is there is a TASKEDITED reportAction that is added to the report. Right now we are hiding it in the front-end, but the necessary changes have been made in the BE to turn this into a visible system message.

What we'll need to have done is:

• Stop hiding the TASKEDITED reportActions
• Ensure that once we make these visible, we also update the visibleReportActions to ensure this is counted
• To handle the offline case, we'll need to optimistically create the message in the for the TASKEDITED reportAction. These optimistic messages will be:

When you update the assignee

• If you remove the assignee, the message should say "removed the assignee"
• If you update the assignee, the message should say "assigned to assignee" <- the assignee should be a mention

When you update the description

• If you remove the description, the message should say "removed the description"
• If you update the description, the message should say "updated the description to [new_description]"

When you update the title, the message should say "updated the task title to [new_task_title]"

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0177e8b2882a2299a2
• Upwork Job ID: 1755757782524846080
• Last Price Increase: 2024-02-09
• Automatic offers:
• paultsimura | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0177e8b2882a2299a2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Need to show the TASKEDITED report actions and create the correct ones optimistically.

What is the root cause of that problem?

This is a feature request.

What changes do you think we should make in order to solve the problem?

First of all, we need to stop hiding this type of actions by removing this piece of code:

App/src/libs/ReportActionsUtils.ts

Lines 359 to 361 in 54d0edf

	if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.TASKEDITED) {
	return false;
	}

Then, we should modify this method (we may consider splitting it into 2 functions: one for fields modification, and another – for the assignees):

App/src/libs/ReportUtils.ts

Lines 3372 to 3402 in 749a395

	function buildOptimisticEditedTaskReportAction(emailEditingTask: string): OptimisticEditedTaskReportAction {
	return {
	reportActionID: NumberUtils.rand64(),
	actionName: CONST.REPORT.ACTIONS.TYPE.TASKEDITED,
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	actorAccountID: currentUserAccountID,
	message: [
	{
	type: CONST.REPORT.MESSAGE.TYPE.TEXT,
	style: 'strong',
	text: emailEditingTask,
	},
	{
	type: CONST.REPORT.MESSAGE.TYPE.TEXT,
	style: 'normal',
	text: ' edited this task',
	},
	],
	person: [
	{
	type: CONST.REPORT.MESSAGE.TYPE.TEXT,
	style: 'strong',
	text: allPersonalDetails?.[currentUserAccountID ?? '']?.displayName ?? currentUserEmail,
	},
	],
	automatic: false,
	avatar: allPersonalDetails?.[currentUserAccountID ?? '']?.avatar ?? UserUtils.getDefaultAvatarURL(currentUserAccountID),
	created: DateUtils.getDBTime(),
	shouldShow: false,
	};
	}

We need to make it more robust and build the report actions with different content depending on the action that was performed – as described in the issue – this action basically should reflect the report action that's coming in the EditTask API response from the Server, so it's a rather trivial task (we are currently implementing a similar thing in #35826 for rooms renaming).

The task is edited in these 2 places:

App/src/libs/actions/Task.ts

Line 452 in fdb0c22

function editTaskAssignee(report: OnyxTypes.Report, ownerAccountID: number, assigneeEmail: string, assigneeAccountID = 0, assigneeChatReport: OnyxEntry<OnyxTypes.Report> = null) {

App/src/libs/actions/Task.ts

Line 382 in fdb0c22

function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task) {

Based on these functions and the data passed to them, we can determine each of the required flows: description/title being updated/removed, or assignee changed/removed. And build each optimistic report action according to the flow it represents.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@eVoloshchak, @thienlnam, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[thienlnam]

cc @eVoloshchak Could you please review the proposal above?

[eVoloshchak]

This is a feature request, and it's a pretty straightforward one, @paultsimura's proposal looks good to me!

🎀👀🎀 C+ reviewed!

[melvin-bot]

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[MitchExpensify]

Not overdue, waiting on some PRs to hit production

Same

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MitchExpensify]

Same: #36768

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.49-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Build optimistic Edit Task actions #36768

If no regressions arise, payment will be issued on 2024-03-18. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @paultsimura requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak / @paultsimura] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[MitchExpensify]

Reminder set to pay!

Payment summary:

C+: $500 @eVoloshchak (NewDot)
C: $500 @paultsimura (Upwork)

[eVoloshchak]

Regression Test Proposal

1. Create a task, click on it to open the task details
2. Go offline
3. Add a description
4. Verify the updated the description to {value} report action is added
5. Modify the title
6. Verify another updated the task title to {value} report action is added
7. Remove the description
8. Verify the removed the description report action is added
9. Assign somebody
10. Verify the assigned to @user report action is added
11. Go back online
12. Refresh the page
13. Verify all the report actions remain

Do we agree 👍 or 👎

[MitchExpensify]

Paid and contract ended. BZ step issue created

[JmillsExpensify]

$500 approved for @eVoloshchak based on summary.