Loading header appears when the sender deletes message and recipient writes in the thread

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707847433641419

Action Performed:

1. Open a chat with B as user A
2. User A sends a message
3. User B replies in the thread
4. User A deletes at the same time

Expected Result:

User B should see "deleted message" in the header when in the thread

Actual Result:

Skeleton is loading for ever and also User A is showing as "Hidden" in the LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[trjExpensify]

I also can't repro this. I stayed on the page and it updated to [Deleted message] in the header and the parent comment previewed:

[trjExpensify]

Discussing in thread.

[MonilBhavsar]

Self assigning as I am working on very similar issue #22186 and came across this bug while fixing the former. I had a brief look and will handle this

https://expensify.slack.com/archives/C049HHMV9SM/p1708085284757179?thread_ts=1707847433.641419&cid=C049HHMV9SM

[MonilBhavsar]

The error comes from this logic

App/src/libs/ReportUtils.ts

Lines 2518 to 2521 in 8907eef

	if (isAdminRoom(report) || isUserCreatedPolicyRoom(report)) {
	return getAdminRoomInvitedParticipants(parentReportAction, parentReportActionMessage);
	}
	return parentReportActionMessage || Localize.translateLocal('parentReportAction.deletedMessage');

For a parent message deleted in #admins or user created room, we enter the condition and return title as empty string
and return early and do not reach the return statement below that returns [Delete Message]

[trjExpensify]

Nice, so @MonilBhavsar.. confirming this hit prod yesterday and we don't have anyone to pay out for the review, so we can go ahead and close this?

[MonilBhavsar]

Yes! Let's close this