-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [TS migration] Migrate VideoPlayerControls
and VideoPopoverMenu
component files to TypeScript
#36723
Comments
Job added to Upwork: https://www.upwork.com/jobs/~013b85f928413973c4 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
Can work on this |
I would like to work on this |
Dibs |
ProposalPlease re-state the problem that we are trying to solve in this issue.Change files to typescript instead of javascript, and add type safety. What is the root cause of that problem?Files were written in javascript, need to change to typescript. What changes do you think we should make in order to solve the problem?Change files to [.ts] and interfaces and types for all necessary variables, functions, and parameters. |
📣 @solowave! 📣
|
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
I am Koustubh, a full stack developer. I’d like to work on this job. |
Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this issue. |
@hayata-suenaga please assign @kowczarz |
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
Hey, I'm leaving the Expensify-SWM team for now and @smelaa will handle this task. |
Hello! I'm Aleksandra Smela from Software Mansion, the expert agency and I would like to work on this issue. |
📣 @smelaa! 📣
|
The BZ member will need to manually hire smelaa for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future! |
PR is in draft |
PR isin draft |
PR isin draft |
Same ^ |
This issue has not been updated in over 15 days. @hayata-suenaga, @situchan, @smelaa eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Triggered auto assignment to @adelekennedy ( |
The PR has been merged. Please handle payment for @situchan for C+ review work |
Payouts due:
|
@adelekennedy I am still using upwork |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files related to the
VideoPlayerControls
andVideoPopoverMenu
componentsUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: