Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [TS migration] Migrate VideoPlayerControls and VideoPopoverMenu component files to TypeScript #36723

Closed
hayata-suenaga opened this issue Feb 16, 2024 · 34 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Typescript Migration

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Feb 16, 2024

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files related to the VideoPlayerControls and VideoPopoverMenu components

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013b85f928413973c4
  • Upwork Job ID: 1758559473458262016
  • Last Price Increase: 2024-02-16
  • Automatic offers:
    • situchan | Reviewer | 0
@hayata-suenaga hayata-suenaga added External Added to denote the issue can be worked on by a contributor Daily KSv2 Typescript Migration labels Feb 16, 2024
@hayata-suenaga hayata-suenaga self-assigned this Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013b85f928413973c4

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@muas19
Copy link

muas19 commented Feb 16, 2024

Can work on this

@rayane-djouah
Copy link
Contributor

I would like to work on this

@ghost
Copy link

ghost commented Feb 16, 2024

Dibs

@TrevorSemeraro
Copy link

Proposal

Please re-state the problem that we are trying to solve in this issue.

Change files to typescript instead of javascript, and add type safety.

What is the root cause of that problem?

Files were written in javascript, need to change to typescript.

What changes do you think we should make in order to solve the problem?

Change files to [.ts] and interfaces and types for all necessary variables, functions, and parameters.

Copy link

melvin-bot bot commented Feb 16, 2024

📣 @solowave! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link

melvin-bot bot commented Feb 16, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@Koustubh-lapate
Copy link

I am Koustubh, a full stack developer. I’d like to work on this job.

@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@kowczarz
Copy link
Contributor

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this issue.

@situchan
Copy link
Contributor

@hayata-suenaga please assign @kowczarz

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@kowczarz
Copy link
Contributor

Hey, I'm leaving the Expensify-SWM team for now and @smelaa will handle this task.

@smelaa
Copy link
Contributor

smelaa commented Feb 20, 2024

Hello! I'm Aleksandra Smela from Software Mansion, the expert agency and I would like to work on this issue.

Copy link

melvin-bot bot commented Feb 20, 2024

📣 @smelaa! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@hayata-suenaga hayata-suenaga assigned smelaa and unassigned kowczarz Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

The BZ member will need to manually hire smelaa for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@situchan
Copy link
Contributor

situchan commented Mar 4, 2024

PR is in draft

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 4, 2024
@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Mar 7, 2024

PR isin draft

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 7, 2024
@hayata-suenaga
Copy link
Contributor Author

PR isin draft

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 11, 2024
@situchan
Copy link
Contributor

Same ^

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Mar 15, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

This issue has not been updated in over 15 days. @hayata-suenaga, @situchan, @smelaa eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@hayata-suenaga hayata-suenaga added the Bug Something is broken. Auto assigns a BugZero manager. label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Apr 10, 2024
@hayata-suenaga
Copy link
Contributor Author

The PR has been merged. Please handle payment for @situchan for C+ review work

@adelekennedy
Copy link

Payouts due:

@situchan
Copy link
Contributor

@adelekennedy I am still using upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Typescript Migration
Projects
No open projects
Development

No branches or pull requests

10 participants