[HOLD for payment 2024-03-19] HIGH: [$500] Magic link - Can't sign in using magic link after going to public room via deeplink

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.42.0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Issue reported by: Applause -Internal team
Slack conversation: Found while executing tests for https://expensify.slack.com/archives/C9YU7BX5M/p1708359665549809

Action Performed:

1. Sign out (if needed) from the app (And kill the app)
2. Navigate to this public room from another app: https://staging.new.expensify.com/r/6776919265133947
3. Click on sign in
4. Open gmail app and click on the sign in magic link

Expected Result:

App should automatically sign the user in

Actual Result:

App doesn't automatically sign the user in after clicking on magic link. user has to use magic code to sign in

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6384808_1708366829777.Screen_Recording_20240219_202408_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01502a04f32100df3d
• Upwork Job ID: 1760726284749012992
• Last Price Increase: 2024-03-07

Issue Owner

Current Issue Owner: @zanyrenney

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[isagoico]

We think this might be related to #36811 but we were not sure. Seems like deeplinking doesn't work twice in a row or just when the app is open in the background.

[mallenexpensify]

Thanks @isagoico, adding to #vip-vsb project.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01502a04f32100df3d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[zanyrenney]

Triaged, thanks for adding to #VIPVSB

[melvin-bot]

@jjcoffee, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jjcoffee]

Waiting for proposals!

[zanyrenney]

still waiting on proposals.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@jjcoffee @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[zanyrenney]

took this here - https://expensify.slack.com/archives/C01GTK53T8Q/p1709567026115789

[melvin-bot]

❌ There was an error making the offer to @jjcoffee for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @bernhardoj for the Contributor role. The BZ member will need to manually hire the contributor.

[flodnv]

@zanyrenney ^ 😕

[bernhardoj]

Let's fix these comments while we're here: #29248 (review)

Addressed in the PR.

PR is ready

cc: @jjcoffee

[zanyrenney]

@jjcoffee @bernhardoj invited you manually to the upwork job, please accept so we can payout when the time comes.

[jjcoffee]

@zanyrenney Applied! 🙏

[bernhardoj]

Applied

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix can't login using magic link when signed in as anonymous user #37952

If no regressions arise, payment will be issued on 2024-03-19. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment (Needs manual offer from BZ)
• @bernhardoj requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

offers sent to @jjcoffee and @bernhardoj on UW ahead of payment tomorrow.

[zanyrenney]

Hmm sctually the offer to @jjcoffee is timing out :

I will do a clean signout tonight and resend.

[zanyrenney]

payment summary

paid $500 to @bernhardoj
offer sent to @jjcoffee

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @jjcoffee paid $500 via Upwork (LINK)
• ROLE: @bernhardoj paid $500) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1760726284749012992/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jjcoffee]

@zanyrenney Accepted the offer, thanks!

[zanyrenney]

payment summary

paid $500 to @bernhardoj
paid $500 to @jjcoffee