Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable setting currency for members #37100

Closed
luacmartins opened this issue Feb 22, 2024 · 7 comments
Closed

Disable setting currency for members #37100

luacmartins opened this issue Feb 22, 2024 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 22, 2024

Currently, workspace members are able to select the Currency row in the Profile page and doing so leads to a not found page. Members shouldn't be able to interact with that row.

cc @narefyev91

@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 22, 2024
@luacmartins luacmartins self-assigned this Feb 22, 2024
Copy link

melvin-bot bot commented Feb 22, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Feb 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor Author

Seems like we no longer need this. This dupe was created and we merged a PR already.

@luacmartins
Copy link
Contributor Author

Gonna close this issue

@github-project-automation github-project-automation bot moved this from Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) to Done in [#whatsnext] Wave 08 - Collect Plan Admins Feb 27, 2024
@luacmartins luacmartins reopened this Feb 28, 2024
@luacmartins
Copy link
Contributor Author

@JmillsExpensify we closed the PR because there was a dupe issue and that PR got merged first. However, @getusha had already completed the checklist, could you help with payment?

@JmillsExpensify
Copy link

JmillsExpensify commented Mar 13, 2024

Payment summary: $500 to @getusha for PR reviews.

@JmillsExpensify
Copy link

All paid out, so closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants