[CRITICAL] [VIP-Travel] [HOLD for payment 2024-05-16] Add Terms and Conditions Modal (NewDot)

[stitesExpensify]

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/views/1?layout=board
Relevant Design Doc Section:

Feature Description

1. Create a new Right Hand Modal (screen) for our travel Terms and Conditions
2. Create a new action for AcceptTravelTerms

Detailed Instructions

A new page, TravelTerms.ts will be created in src/pages/Travel: If the user is not on the travel beta, we’ll display a [blocking View ](https://github.com/Expensify/App/blob/main/src/components/BlockingViews/FullPageNotFoundView.tsx)instead It will include a [HeaderWithBackButton](https://github.com/Expensify/App/blob/main/src/components/HeaderWithBackButton/index.tsx) component with “Before we continue…” as the title. It will include the text displayed above (hyperlinks TBD) and a [checkboxWithLabel](https://github.com/Expensify/App/blob/main/src/components/CheckboxWithLabel.tsx) component for the user to agree with the terms. Lastly, it will include a (disabled until the checkbox is checked) as shown above: On click, it will call a new command, [AcceptTravelTerms](https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit?pli=1#bookmark=id.1b1k3v847xja), to update NVP.travelSettings.hasAcceptedTerms or provision the workspace, and redirect the user to travel.expensify.com. If network.isOffline is true, it will be disabled, and the usual “You appear to be offline” message will display below.

Manual Test Steps

1. Log in on a new account
2. Create a workspace
3. Go to travel
4. Click the book travel button
5. Make sure the T&C appears
6. Make sure that if you don't check the box you cannot accept t&c
7. Accept the T&C
8. Look at the network request and ensure that we returned new policy and user data for the newly provisioned accounts

Automated Tests

Test for AcceptTravelTerms action

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a02f3de0cecfaf7
• Upwork Job ID: 1760758341962240000
• Last Price Increase: 2024-02-22

Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a02f3de0cecfaf7

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[stitesExpensify]

Re-assigning this to Ted since he is curating this implementation. Also temporarily removing c+ since this project has not started yet

[cdOut]

Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I'd like to work on this task.

[twisterdotcom]

Great! Assigned you @cdOut

[shubham1206agra]

@twisterdotcom Please assign me here too.

[cdOut]

As an update, I’ll be creating a draft PR for this feature and also the main travel page today.

[twisterdotcom]

Possible we'll hold this and not requie a ToS interstitial: https://expensify.slack.com/archives/C05S5EV2JTX/p1711726076366499

[twisterdotcom]

See PR comment here: #38469 (comment)

[twisterdotcom]

Can we make this ready for review yet @cdOut? The URL for the travel terms will be use.expensify.com/travelterms

[cdOut]

@twisterdotcom We'll prioritize on pushing this through review.

[rushatgabhane]

all set. PR merged

[twisterdotcom]

This is on Prod right? We just need to pay out @rushatgabhane and @shubham1206agra now I think?

[twisterdotcom]

Payment Summary:

• @shubham1206agra paid $500 here (C+)
• @rushatgabhane paid $500 via newDot requests

[JmillsExpensify]

$500 approved for @rushatgabhane