Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-20] [$500] [Wave Collect] [More Features] Create WorkspaceMoreFeaturesPage in App #37373

Closed
mountiny opened this issue Feb 27, 2024 · 34 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented Feb 27, 2024

Part of https://github.com/Expensify/Expensify/issues/365143

Implement this section of the design doc.

This is not on HOLD per se, we can develop the UI now and then merge once the backend is ready for it.

cc @narefyev91

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0199f8f951b5430173
  • Upwork Job ID: 1762624586850594816
  • Last Price Increase: 2024-02-27
Issue OwnerCurrent Issue Owner: @kevinksullivan
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 27, 2024
@mountiny mountiny self-assigned this Feb 27, 2024
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Feb 27, 2024
@melvin-bot melvin-bot bot changed the title [Wave8] [More Features] Create WorkspaceMoreFeaturesPage in App [$500] [Wave8] [More Features] Create WorkspaceMoreFeaturesPage in App Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0199f8f951b5430173

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 27, 2024
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
@mountiny
Copy link
Contributor Author

Not looking for external help, agency will handle it

@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37
Copy link
Contributor

I created some draft UI. I need to clarify icons, titles, subtitles and so on. Please provide me more info. Thank you!

List Empty

Copy link

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

@mountiny
Copy link
Contributor Author

@shawnborton could you please help with #37441 (comment) thank you

@shawnborton
Copy link
Contributor

Will do! I'll try to get to this tomorrow morning and if not, will reassign to another @Expensify/design member

@shawnborton
Copy link
Contributor

Added them here

@rezkiy37
Copy link
Contributor

Actively working on the issue.

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@s77rt
Copy link
Contributor

s77rt commented Mar 4, 2024

Not overdue. @mountiny Can you please assign @rezkiy37

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 13, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 13, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Wave Collect] [More Features] Create WorkspaceMoreFeaturesPage in App [HOLD for payment 2024-03-20] [$500] [Wave Collect] [More Features] Create WorkspaceMoreFeaturesPage in App Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@s77rt
Copy link
Contributor

s77rt commented Mar 14, 2024

Regression Test Proposal

(Requires a paid workspace with admin role)

  1. Open App
  2. Go to Profile > Workspaces > Paid workspace
  3. Verify there is a tab "More features" and click on it
  4. Enable any feature
  5. Verify the feature is added to the LHP
  6. (Web/Desktop only) Verify you are redirected to that feature's page
  7. Disable any feature
  8. Verify the feature is removed from the LHP

@luacmartins
Copy link
Contributor

We'll add regression tests as part of the design doc once the feature is fully implemented.

Copy link

melvin-bot bot commented Mar 20, 2024

Payment Summary

Upwork Job

  • ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@kevinksullivan)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1762624586850594816/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@shawnborton
Copy link
Contributor

Not overdue, looks like we're working on payment details above.

@mountiny
Copy link
Contributor Author

$500 to @s77rt

@luacmartins
Copy link
Contributor

@kevinksullivan Was this paid out? Can we close it?

@luacmartins
Copy link
Contributor

Bump for payment @kevinksullivan

@luacmartins
Copy link
Contributor

Bump for payment

@s77rt
Copy link
Contributor

s77rt commented Apr 3, 2024

Payment due is $125 for two regressions (#38185 and #38198)

Copy link

melvin-bot bot commented Apr 5, 2024

@shawnborton, @s77rt, @luacmartins, @kevinksullivan, @mountiny 10 days overdue. I'm getting more depressed than Marvin.

@kevinksullivan
Copy link
Contributor

sorry for the delay, new job created and paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

7 participants