Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [Simplified Collect][Distance Rates] Implement CreateDistanceRatePage #37512

Closed
luacmartins opened this issue Feb 29, 2024 · 26 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 29, 2024

Implement PolicyNewDistanceRatePage following the specifications in the design doc

cc @MrMuzyk

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01350a6fa3ed44b2b0
  • Upwork Job ID: 1763222767227588608
  • Last Price Increase: 2024-02-29
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 29, 2024
@luacmartins luacmartins self-assigned this Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Feb 29, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 29, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Distance Rates] Implement PolicyNewDistanceRatePage [$500] [Simplified Collect][Distance Rates] Implement PolicyNewDistanceRatePage Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01350a6fa3ed44b2b0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Current assignee @mallenexpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 29, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Mar 4, 2024

Since @MrMuzyk is assigned, I believe this should be weekly, updated

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Mar 4, 2024
@luacmartins luacmartins moved this to Release 2: From Setup > Export in [#whatsnext] Wave 08 - Collect Plan Admins Mar 5, 2024
@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@luacmartins luacmartins removed the Weekly KSv2 label Apr 8, 2024
@mallenexpensify
Copy link
Contributor

@situchan , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01191015db3d9f269d

@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2024
@luacmartins
Copy link
Contributor Author

Still waiting on payment

@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2024
@mallenexpensify
Copy link
Contributor

@situchan is OOO, bumping to weekly.

@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Apr 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2024
@luacmartins
Copy link
Contributor Author

Pending payment

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2024
@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
@mallenexpensify
Copy link
Contributor

@situchan back soon

@melvin-bot melvin-bot bot removed the Overdue label May 7, 2024
@melvin-bot melvin-bot bot added the Overdue label May 16, 2024
@mallenexpensify
Copy link
Contributor

Still waiting for @situchan to return.

@melvin-bot melvin-bot bot removed the Overdue label May 18, 2024
@situchan
Copy link
Contributor

I returned. Can you please send new offer?

@mallenexpensify
Copy link
Contributor

mallenexpensify commented May 22, 2024

Welcome back! @situchan can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01808847a707e339cb

@mallenexpensify mallenexpensify added Daily KSv2 and removed Weekly KSv2 labels May 22, 2024
@situchan
Copy link
Contributor

Accepted thanks

@mallenexpensify
Copy link
Contributor

Contributor+: @situchan paid $500 via Upwork.

@situchan @luacmartins I'm assuming we want a TestRail GH for this since it's a new feature. If you agree, @situchan , please provide the steps to add. Thx

@mallenexpensify
Copy link
Contributor

Ping on needing a TestRail case for this

@mallenexpensify mallenexpensify changed the title [HOLD for payment 2024-03-26] [$500] [Simplified Collect][Distance Rates] Implement CreateDistanceRatePage [$500] [Simplified Collect][Distance Rates] Implement CreateDistanceRatePage May 24, 2024
@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@situchan
Copy link
Contributor

Regression Test Proposal

  1. Login account with paid policy that has access to distance rates page
  2. Go to Account settings > Workspaces > paid policy > Distance rates
  3. Click "Add rate" and enter amount
  4. Click "Save
  5. Verify that new rate is added successfully

@melvin-bot melvin-bot bot removed the Overdue label May 27, 2024
@luacmartins
Copy link
Contributor Author

luacmartins commented May 27, 2024

No TR tests needed. We already added this as part of the project wrap up. Gonna close this issue, please reopen if we're missing something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 2: From Setup > Export
Development

No branches or pull requests

4 participants