Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-29] [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRateSettingsPage #37513

Closed
luacmartins opened this issue Feb 29, 2024 · 33 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 29, 2024

Implement PolicyDistanceRateSettingsPage following the specifications in the design doc

cc @MrMuzyk

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010902f2b08cb0564b
  • Upwork Job ID: 1763223051466571776
  • Last Price Increase: 2024-02-29
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 29, 2024
@luacmartins luacmartins self-assigned this Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Feb 29, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 29, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Distance Rates] Implement PolicyDistanceRateSettingsPage [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRateSettingsPage Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010902f2b08cb0564b

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 29, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. and removed Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

Copy link

melvin-bot bot commented Feb 29, 2024

Current assignee @sakluger is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 29, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 29, 2024
@hereistopdev
Copy link

I am a freelancer from Upwork, I would like to work on this issue

This comment was marked as resolved.

@hereistopdev

This comment was marked as resolved.

This comment was marked as resolved.

@hereistopdev
Copy link

I am ready to start work right now

@luacmartins
Copy link
Contributor Author

@hereistopdev thanks for the interest. However, we already assigned someone to work on this issue.

@hereistopdev
Copy link

ok
You are welcome

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
@ishpaul777
Copy link
Contributor

not overdue

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Mar 18, 2024
Copy link

melvin-bot bot commented Mar 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@parasharrajat
Copy link
Member

Are we going to create a follow-up PR?

@luacmartins
Copy link
Contributor Author

@parasharrajat to fix #38662? I think @MrMuzyk is assigned and will work on a fix.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 22, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRateSettingsPage [HOLD for payment 2024-03-29] [$500] [Simplified Collect][Distance Rates] Implement PolicyDistanceRateSettingsPage Mar 22, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 22, 2024
Copy link

melvin-bot bot commented Mar 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

  • @MrMuzyk does not require payment (Contractor)
  • @ishpaul777 requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 22, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@luacmartins
Copy link
Contributor Author

Just pending payment

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@luacmartins luacmartins reopened this Apr 1, 2024
@parasharrajat
Copy link
Member

Looks like there is no pending payment here.

@ishpaul777
Copy link
Contributor

I haven't been paid yet @parasharrajat, looks like the follow up is handled as a different issue i never got assigned to that issue 🤔

@sakluger
Copy link
Contributor

sakluger commented Apr 8, 2024

Sorry for the delay, I'll handle payment now. Just to confirm, there was a regression on this issue's PR, correct? So the payment would be $250?

@sakluger sakluger added Daily KSv2 and removed Weekly KSv2 labels Apr 8, 2024
@ishpaul777
Copy link
Contributor

@sakluger @luacmartins will that issue be counted as regression, there's a few polish things left with new feature PR do we count it as regression never happened to me on any previous issue so just asking..

@luacmartins
Copy link
Contributor Author

I don't think that was a regression since the feature didn't exist yet. I think the full l$500 still applies in this case.

@sakluger
Copy link
Contributor

sakluger commented Apr 9, 2024

Got it, thanks for confirming!

@ishpaul777 I've sent you an offer via Upwork: https://www.upwork.com/nx/wm/offer/101802947

@ishpaul777
Copy link
Contributor

Accepted! Thanks 😄

@sakluger
Copy link
Contributor

sakluger commented Apr 9, 2024

Awesome, thanks! 🙌

@sakluger sakluger closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 2: From Setup > Export
Development

No branches or pull requests

6 participants