Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Workspace owner can be checked marked on Members page #37555

Closed
6 tasks done
lanitochka17 opened this issue Feb 29, 2024 · 8 comments
Closed
6 tasks done

Workspace - Workspace owner can be checked marked on Members page #37555

lanitochka17 opened this issue Feb 29, 2024 · 8 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: applausetester+gm51@applause.expensifail.com
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Create Workspace
  2. Go to Members page
  3. Try to checkmark the Owner

Expected Result:

Owner should not be checkmarkable

Actual Result:

Workspace owner can be checked marked on Members page/ Remove option becomes active but unresponsive

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6397431_1709231269530.Recording__2408.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@lanitochka17
Copy link
Author

@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@rushatgabhane
Copy link
Member

rushatgabhane commented Feb 29, 2024

Proposal

Root cause

The menu item is disabled for these conditions -

isDisabled:
accountID === session?.accountID ||
details.login === policy?.owner ||
but no such check is added for toggling the user.

Solution

We should add similar checks when toggling the user -

if (pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {

@aimane-chnaif
Copy link
Contributor

This maybe not a blocker, coming from new feature. We can fix this as follow-up.
cc: @luacmartins

@luacmartins
Copy link
Contributor

We'll address this as part of #37199. NAB since the owner can't actually be removed.

@luacmartins
Copy link
Contributor

Closing in favor of #37199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants