[$500] [HOLD for payment 2024-03-19] Do not show "member not found" when loading member list

[luacmartins]

Coming from this comment, we should not show "member not found" while loading the member list

cc @burczu

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d5126ce1290525b2
• Upwork Job ID: 1770042366576177152
• Last Price Increase: 2024-03-19

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aimane-chnaif]

Happy to review this as C+

[rayane-djouah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

we are showing "member not found" while loading the member list.

What is the root cause of that problem?

Here:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 352 to 357 in 85dc2f6

	const getHeaderMessage = () => {
	if (isOfflineAndNoMemberDataAvailable) {
	return translate('workspace.common.mustBeOnlineToViewMembers');
	}
	return !data.length ? translate('workspace.common.memberNotFound') : '';
	};

when data is empty we show the "member not found" message, but we should not show it when members are still loading

What changes do you think we should make in order to solve the problem?

we should use the same condition used here:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 461 in 85dc2f6

showLoadingPlaceholder={!isOfflineAndNoMemberDataAvailable && (!OptionsListUtils.isPersonalDetailsReady(personalDetails) || isEmptyObject(policyMembers))}

in getHeaderMessage function, like this:

    const getHeaderMessage = () => {
        if (isOfflineAndNoMemberDataAvailable) {
            return translate('workspace.common.mustBeOnlineToViewMembers');
        }
        return (!data.length && (!OptionsListUtils.isPersonalDetailsReady(personalDetails) || isEmptyObject(policyMembers))) ? translate('workspace.common.memberNotFound') : '';
    };

[aimane-chnaif]

I am not sure this will be be external.
@burczu may take this.

[burczu]

Hey I'm Bartek from Callstack - could you please assign this issue to me?

[burczu]

not overdue - I'll work on this today

[burczu]

The PR is ready for review: #37731

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• #37605 Do not show "member not found" when loading member list #37731

If no regressions arise, payment will be issued on 2024-03-19. 🎊

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d5126ce1290525b2

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

[zanyrenney]

@aimane-chnaif invited you to job on UW - https://www.upwork.com/jobs/~01d5126ce1290525b2 pls accept for payout.

[zanyrenney]

accepted proposal.

[zanyrenney]

payment summary:
@burczu does not require payment (Contractor)
@aimane-chnaif requires payment (Needs manual offer from BZ) - paid $500 on Upwork.