Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mweb - Tapping green fab does not open the menu docking to the bottom #3768

Closed
kavimuru opened this issue Jun 26, 2021 · 29 comments · Fixed by #3856
Closed

mweb - Tapping green fab does not open the menu docking to the bottom #3768

kavimuru opened this issue Jun 26, 2021 · 29 comments · Fixed by #3856
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open e.cash in mWeb
  2. Click + button

Expected Result:

when I tap the + fab button context menu should popup docking to the bottom

Actual Result:

Page is greyed out and context menu does not open.

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: 1.0.74-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Issue occurs in android chrome browser SG 10 / chrome and Samsung Galaxy A50 / chrome
Expensify/Expensify Issue URL:

Bug5128146_20210626_015503.mp4

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico
Copy link

isagoico commented Jun 26, 2021

Here's the browser resolution of the device (in which the issue was reproducible)

@Luke9389 Luke9389 added the External Added to denote the issue can be worked on by a contributor label Jun 28, 2021
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Luke9389
Copy link
Contributor

Seems like a good external issue

@roryabraham roryabraham added the DeployBlockerCash This issue or pull request should block deployment label Jun 28, 2021
@roryabraham
Copy link
Contributor

I think this should be a deploy blocker.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jun 28, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rdjuric
Copy link
Contributor

rdjuric commented Jun 28, 2021

Wasn't able to reproduce it

@parasharrajat
Copy link
Member

I can't reproduce this.

@roryabraham
Copy link
Contributor

@isagoico Which mobile browser were you able to reproduce this in?

@isagoico
Copy link

We were able to reproduce on devices with this browser resolution

@Luke9389
Copy link
Contributor

Tested just now and haven't been able to reproduce. Gonna switch my emulator to a Samsung Galaxy A50 and try again.

@Luke9389
Copy link
Contributor

@parasharrajat and @rdjuric did you try with a Samsung Galaxy A50 or a SG 10?

@isagoico
Copy link

Just asked the testers again if they are able to reproduce the issue. Will post here the results.

@isagoico
Copy link

isagoico commented Jun 29, 2021

Tester is still able to reproduce on Chrome browser / SG A50

20210629_133500.mp4

@Luke9389
Copy link
Contributor

@isagoico Can we test if this is occurring on production as well?

@roryabraham
Copy link
Contributor

roryabraham commented Jun 29, 2021

Hmmm I'm unfortunately not able to reproduce in Chrome's responsive mode at that aspect ratio

@rdjuric
Copy link
Contributor

rdjuric commented Jun 29, 2021

I was able to reproduce this by changing my chrome settings: Settings -> Accessibility -> Force Enable Zoom, gives the exact behavior of the video.

Can we confirm if the tester has this accessibility setting enabled? I don't think it's a default on any Chrome version.

@isagoico
Copy link

Issue is also reproducible in production

@Luke9389 Luke9389 removed the DeployBlockerCash This issue or pull request should block deployment label Jun 29, 2021
@Luke9389
Copy link
Contributor

Ok cool, gonna take the DeployBlockerCash off of this then.

@isagoico
Copy link

I was able to reproduce this by changing my chrome settings: Settings -> Accessibility -> Force Enable Zoom, gives the exact behavior of the video.
Can we confirm if the tester has this accessibility setting enabled? I don't think it's a default on any Chrome version.

Tester verified if she had the accessibility setting enabled and it had the default setting so not sure if it's caused because of this.

@Luke9389 Luke9389 added Daily KSv2 and removed Hourly KSv2 labels Jun 29, 2021
@Luke9389
Copy link
Contributor

Ok so now that we know this issue is just a bug that's been on production I think we are safe to post this on Upwork @MitchExpensify. One prerequisite that we'll need to check off is that the contractor can actually reproduce this.

@MitchExpensify
Copy link
Contributor

Adding Upwork job!

@MitchExpensify
Copy link
Contributor

Upwork job

@parasharrajat
Copy link
Member

@Luke9389 Just solved it #3781 (comment) with another issue.

Please consider that solution as a single Proposal for both of the issues.

@Luke9389
Copy link
Contributor

Luke9389 commented Jul 1, 2021

Nice! Ok, so I guess we will skip over the proposal section here. Once you get the green light on that other issue, please link this issue in that PR description so that this thread is easy to follow. @MitchExpensify, we can take the job down from Upwork.

@MitchExpensify
Copy link
Contributor

Done!

@MitchExpensify
Copy link
Contributor

Update - I've reopened the Upwork job and we will be tracking it here (#3781) instead of seeing as that change fixes this issue too. With that, I think we can probably close this issue in favor or #3871 right?

@parasharrajat
Copy link
Member

So I suggest we keep this open and Let it be closed by PR as this is a different issue even though the solution I proposed will work for both.

@MitchExpensify
Copy link
Contributor

Sounds good @parasharrajat !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants