[HOLD for payment on July 7] Web - Profile - Deleted Profile name updated only after page refresh

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Upwork Job: https://www.upwork.com/jobs/~0133c0817f9a59ef1d

---

Action Performed:

1. Go to https://staging.expensify.cash
2. Log in with user (should Last and First name filled) and click on Avatar Picture
3. Click on Profile
4. Delete Last and First name

Expected Result:

Profile page should be displayed as email or phone number. it should work without the refresh

Actual Result:

Profile name appears until the page is refreshed

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App
Mobile Web ✔️

Version Number: 1.0.74-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5128938_Recording__184.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[rdjuric]

Proposal

This happens because we're not merging our local changes in the case of an empty first and last name. This conditional looks unnecessary since our getDisplayName function already deals with the case of an empty name.

By removing it we get the expected behavior:

web.mov

[Jag96]

@rdjuric good find! Your proposal looks good to me, I've invited you to the Upwork job (https://www.upwork.com/jobs/~0133c0817f9a59ef1d). Please accept the invite there and once the offer is sent you're good to start on a PR!

[Jag96]

Offer sent!

[Jag96]

Paid!