[HOLD for payment 2024-06-28] [MEDIUM] Create Trip Room Preview

[stitesExpensify]

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.6c8m84z62q6z

This issue is for creating another new preview type, this time for trip rooms:

• A new component, TripRoomPreview will be created in src/components/ReportActionItem.
• A new action type, ACTION_TRIPPREVIEW, will be added to CONST.ts.
• If the report action is of the new type, which we will check in ReportActionItem.js, the new component will be displayed.
• TripRoomPreview will mimic ReportPreview’s formatting and behavior with some notable changes:
  • We’ll display the room name under the total
• Receipts will not be displayed.
• Instead, a new helper function, getTripTransactions(expenseReportID) will be created in ReportUtils, and will return any transaction with travel details. We’ll display those details as shown in the mockup.
• On click, it’ll take the user to the trip room via Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));

Issue Owner

Current Issue Owner: @twisterdotcom

[WojtekBoman]

Hey! I’m Wojtek from Software Mansion, the expert agency, and I’d like to work on this issue.

[twisterdotcom]

Adding a C+ here for Travel reviews: @shubham1206agra

[twisterdotcom]

Only assigned on Friday. We can give them a day here Melvin.

[melvin-bot]

@twisterdotcom, @WojtekBoman, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

Are we waiting on anything internal here?

[twisterdotcom]

Bump on that last Q today @WojtekBoman.

[WojtekBoman]

Sorry I was OOO, I'm currently waiting for a response from @stitesExpensify here

[WojtekBoman]

@shawnborton How do we want to format the trip duration text when the start and end dates are in different months/years?

[shawnborton]

Good question. Maybe we should standardize on something like:

• Mar 17-20
• Feb 28 to Mar 1
• Dec 28, 2023 to Jan 5, 2024

When we do timestamps on messages in the product, we do the month abbreviation (Jan, Feb, Mar, etc) so I think we should stay consistent here too.

cc @Expensify/design @twisterdotcom @ryanschaffer @stitesExpensify for thoughts on that

[dannymcclain]

I like the formats you've laid out.

[twisterdotcom]

Agree with this. Why would we do:

Feb 28 to March 1

And not:

Feb 28 to Mar 1

[shawnborton]

Totally agree, that was a typo on my part! Will update my comment.

[WojtekBoman]

@twisterdotcom I see in the Spotnana documentation that we can also book a rail travel or a limo. Spotnana also provides trip type: miscellaneous. Do we want to handle these types of trips as well?

Spotnana docs: https://developer.spotnana.com/openapi/trip/#operation/getTripDetailsV3

[twisterdotcom]

Rail definitely... limo or misc, man that's the first I see. Let me quickly on our call in a bit if they can provide some colour on what those would be. I'm guessing maybe we could bundle those in to the other categories, or perhaps we'll need our own.

From your perspective, would it be easier to just separate them just as Spotnana do, and we find some icons to match?

[WojtekBoman]

Yes, I think the best solution for us would be to have separate types for them and display the appropriate icons based on that

[twisterdotcom]

Okay, there won't be any limos, that's a specific paid VIP extra we're not handling yet.

Misc might happen, can be random things like ferries which sometimes are booked with rail travel tickets etc. So, we could just use the luggage icon for those, right @shawnborton / @dannymcclain?

[dannymcclain]

@twisterdotcom Yeah that's probably what I'd do. I went ahead and mapped some icons from our system to these categories (potential alternates in the light gray)

🙏 please don't make me make a limo icon 🤣

[twisterdotcom]

This is off hold now! You should be able to get moving on it now.

[melvin-bot]

@twisterdotcom, @WojtekBoman, @shubham1206agra, @smelaa Huh... This is 4 days overdue. Who can take care of this?

[twisterdotcom]

Do we have a PR ongoing now?

[WojtekBoman]

Do we have a PR ongoing now?

Yes #38808. I see that trip data is already available in NewDot, so I'll continue working on that today

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [VIP-Travel] Create Trip Room Preview #38808

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)
• @shubham1206agra requires payment (Needs manual offer from BZ)
• @smelaa does not require payment (Contractor)

[twisterdotcom]

Payment Summary:

• @WojtekBoman does not require payment (Contractor)
• @shubham1206agra paid $500 here
• @smelaa does not require payment (Contractor)

[shubham1206agra]

@twisterdotcom This issue was created and assigned before April 6. I think bounty should be $500.

[twisterdotcom]

Thanks! Just updated it.