Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-04-05] [$500] [Simplified Collect][Workflows] Prevent full screen loading on Workflows page if data is present #38153

Closed
luacmartins opened this issue Mar 12, 2024 · 26 comments
Closed

[HOLD for payment 2024-04-05] [$500] [Simplified Collect][Workflows] Prevent full screen loading on Workflows page if data is present #38153

luacmartins opened this issue Mar 12, 2024 · 26 comments
Assignees
@luacmartins @jjcoffee @joekaufmanexpensify @ishpaul777
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Mar 12, 2024 •
edited by melvin-bot bot
Loading

Coming from this comment, we should prevent the full screen loader on the Workflows page when coming back online since we already have local data. We should keep displaying stale data until the request finishes and potentially updates any outdated data.

cc @ishpaul777 @jjcoffee since you worked on that issue.

desktop-app-2024-03-12_14.47.19.mp4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01323c49a4c07b3a5f
  • Upwork Job ID: 1767641402691878912
  • Last Price Increase: 2024-03-12
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 12, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 12, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@luacmartins luacmartins mentioned this issue Mar 12, 2024
Merged
50 tasks
@luacmartins luacmartins changed the title Prevent full screen loading on Workflows page if data is present [Simplified Collect][Workflows] Prevent full screen loading on Workflows page if data is present Mar 12, 2024
@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Mar 12, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Workflows] Prevent full screen loading on Workflows page if data is present [$500] [Simplified Collect][Workflows] Prevent full screen loading on Workflows page if data is present Mar 12, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01323c49a4c07b3a5f

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 12, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 12, 2024

Current assignees @jjcoffee and @ishpaul777 are eligible for the External assigner, not assigning anyone new.

@joekaufmanexpensify
Copy link
Contributor

Seems like this is a cleanup issue, and @ishpaul777 and @jjcoffee are going to work on this. LMK if there's anything I can help with in the meantime!

@joekaufmanexpensify joekaufmanexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 14, 2024
@joekaufmanexpensify
Copy link
Contributor

@luacmartins @ishpaul777 @jjcoffee what are the next steps for this?

@melvin-bot melvin-bot bot removed the Overdue label Mar 14, 2024
@luacmartins
Copy link
Contributor Author

@ishpaul777 should work on a PR to fix the issue.

@ishpaul777
Copy link
Contributor

I'll take a look today

@ishpaul777 ishpaul777 mentioned this issue Mar 15, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 15, 2024
@joekaufmanexpensify
Copy link
Contributor

Great. TY!

@joekaufmanexpensify
Copy link
Contributor

PR merged

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Simplified Collect][Workflows] Prevent full screen loading on Workflows page if data is present [HOLD for payment 2024-04-05] [$500] [Simplified Collect][Workflows] Prevent full screen loading on Workflows page if data is present Mar 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 29, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Mar 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @jjcoffee requires payment (Needs manual offer from BZ)
  • @ishpaul777 requires payment (Needs manual offer from BZ)

@melvin-bot Melvin Bot

This comment was marked as off-topic.

Sign in to view
@mountiny mountiny mentioned this issue Mar 29, 2024
Closed
6 tasks
@joekaufmanexpensify
Copy link
Contributor

@jjcoffee is checklist needed for this one?

@luacmartins
Copy link
Contributor Author

@joekaufmanexpensify I think we can skip it since the feature was still in development when this bug was reported.

@joekaufmanexpensify
Copy link
Contributor

Sounds good. Is separate payment needed for this, or this is something that should've been handled in the issue you linked in OP?

@luacmartins
Copy link
Contributor Author

Yes, this requires a separate payment.

@joekaufmanexpensify
Copy link
Contributor

cool cool. TY!

@joekaufmanexpensify
Copy link
Contributor

We need to pay:

@joekaufmanexpensify
Copy link
Contributor

offers sent to both of you!

@ishpaul777
Copy link
Contributor

Thank you! Accepted offer

@jjcoffee
Copy link
Contributor

jjcoffee commented Apr 5, 2024

@joekaufmanexpensify Offer accepted, thanks!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 5, 2024 •
edited by joekaufmanexpensify
Loading

Payment Summary

Upwork Job

  • ROLE: @jjcoffee paid $(AMOUNT) via Upwork (LINK)
  • ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@joekaufmanexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1767641402691878912/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@joekaufmanexpensify
Copy link
Contributor

@ishpaul777 $500 sent and contract ended!

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@joekaufmanexpensify
Copy link
Contributor

@jjcoffee $500 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

All set. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@jjcoffee jjcoffee

@joekaufmanexpensify joekaufmanexpensify

@ishpaul777 ishpaul777

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
No open projects
[#whatsnext] #wave-collect
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luacmartins @jjcoffee @joekaufmanexpensify @ishpaul777