[$500] Workspace - App does not open WS chat after creating a new workspace and returning to Chats

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com.
2. Open workspace switcher.
3. Click + icon.
4. Return to Chats via Chat icon.

Expected Result:

Chats will open the newly created workspace chat (production behavior).

Actual Result:

Chats open the last chat instead of workspace chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6412995_1710381136311.bandicam_2024-03-14_09-47-16-462.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0141b4522dd13095c1
• Upwork Job ID: 1768259210734514176
• Last Price Increase: 2024-03-14

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@MariaHCD I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chats open the last chat instead of workspace chat.

What is the root cause of that problem?

After Idea nav2 is complete, workspace setting is moved to FullScreenNavigator and when we create a new workspace we don't switch navigate to new policy so after we back to chat, the active policy isn't changed

App/src/libs/actions/App.ts

Line 332 in b7a230e

Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));

What changes do you think we should make in order to solve the problem?

We should switch the active policyID here before navigating to workspace initial page

Navigation.navigateWithSwitchPolicyID({policyID});
Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));

App/src/libs/actions/App.ts

Line 332 in b7a230e

Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));

OPTIONAL: we can add an extra param in this function like shouldSwitchPolicy with default value as false and call Navigation.navigateWithSwitchPolicyID if it's true and then we will pass shouldSwitchPolicy as true when we click on plus icon of WorkspaceSwitcherPage

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0141b4522dd13095c1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

@nkdengineer Since this is a deploy blocker, are you able to identify the PR that caused this?

[nkdengineer]

@jjcoffee This PR #37421 cause this.

[luacmartins]

@WojtekBoman @mountiny seems like a regression from ideal nav v2

[kosmydel]

I think this one is expected (source):

Accessing a workspace via the 🔧 resulted in a "lateral," global switch of someone's workspace. This was confusing because we created one known, obvious way to switch a worked – the workspace switcher – and then one secret, confusing way to "laterally" switch a workspace by choosing it in Settings.

The workspace in settings is no longer "connected" to the LHN workspace. It's a design change.

cc @mountiny, @trjExpensify

[mountiny]

I think this does not have to be a blocker, I will assign myself and discuss if we want to keep this behaviour in the new design

[mountiny]

@kosmydel this is not about selecting the workspace or not

When new workspace was created, the user was navigated to the admins room before this change, not to the settings

[nkdengineer]

@mountiny When we create a new workspace, I think we can switch policy before we navigate to the setting workspace so after we click on back button in header of setting page, we can see the releated reports of the new workspace.

[mountiny]

After discussing this is now going to be expected, not all workspaces will have admin rooms #36236 so navigating to settings is the best option.

@kavimuru @izarutskaya @isagoico Could you update testRail about this?

[isagoico]

This TC should cover this behavior - Workspace Creation - Online