[Awaiting Payment 30th April] [Wave Collect] [More Features] [$500] Feature enabled from more features are not highlighted when user taken back to the LHN

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710462111227289

Action Performed:

1. open app
2. go to any collect workspace
3. Tap more features
4. Enable any option
5. Look at the LHN

Expected Result:

the row of the enabled option is highlighted when we take the user back to the LHN.

Actual Result:

the enabled option is not highlighted when we take the user back to the LHN.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1710473724.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c04b62c76b203710
• Upwork Job ID: 1768687467296501760
• Last Price Increase: 2024-04-30
• Automatic offers:
• rojiphil | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c04b62c76b203710

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot]

Upwork job price has been updated to $250

[mountiny]

Should use similar solution to what we have here #38036

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[mountiny]

Rushat will handle this

[trjExpensify]

@luacmartins @mountiny should we do categories and tags here as well?

[mountiny]

We could

@rushatgabhane that means we will add the same highlight as with new Member from #38036 for new category and tag

[rushatgabhane]

Before we implement this. I noticed an UX inconsistency between platforms.

Web: Enabling a feature navigates you to the feature.
Mobile: Enabling a feature navigates you to LHN.

Our philosophy is to have same UX across platforms. So shouldn't we make the UX consistent i.e. navigate to the enabled feature directly?

cc: @shawnborton

Screen.Recording.2024-03-15.at.23.28.03.mov

[mountiny]

@allroundexperts have you got all you need in that PR, seems like design team has weighed in

[allroundexperts]

@allroundexperts have you got all you need in that PR, seems like design team has weighed in

Yes, I'm on it. I'm not sure how the transitions would work, but rest of the feedback should be easy to put in.

[luacmartins]

I think the border radius disappeared again:

[allroundexperts]

Oh, that's weird. I'm checking this.

[luacmartins]

I think we need to add the styles here, because combinedStyle > styles.popoverMenuItem sets borderRadius to 0

Another issue, it seems like the height got shorter and now the highlights overlap

Screen.Recording.2024-04-04.at.2.34.17.PM.mov

[allroundexperts]

The amount of overlap looks the same to me.

[allroundexperts]

Created draft PR #39657. Filling in the checklist now. Feel free to review to make things faster.

[allroundexperts]

Ready for review.

[mountiny]

Not sure if related but do you see this behaviour when toggling the distance rate feature repeatedly?
https://github.com/Expensify/App/assets/36083550/bcf33aec-37fb-4edb-a766-a24e33b5eb62

[allroundexperts]

Doesn't look related to me.

[melvin-bot]

This issue has not been updated in over 15 days. @rojiphil, @trjExpensify, @luacmartins, @allroundexperts, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[luacmartins]

Is this issue done? I can't reproduce this anymore

[trjExpensify]

What's with all the automation failures as of late man. I think this is ready for payment. @allroundexperts if you want to confirm, and then I'll jump on that.

[rojiphil]

I think this is ready for payment.

@trjExpensify Also please note. I was involved in the review of this issue (Reference)

[allroundexperts]

Yes. This is ready for payment.

Also, since the issue later on had a scope change and involved adding animations as well, I would request the bounty to be $500. @mountiny can you please weigh in?

Thanks!

[melvin-bot]

Upwork job price has been updated to $500

[trjExpensify]

Yeah, this one ended up being a tricky one for simplified collect. I think we can keep it at $500

Payment summary as follows:

• $500 to @allroundexperts for the fix
• $500 to @rojiphil for the C+ review

[trjExpensify]

• @rojiphil paid
• @allroundexperts - go ahead and submit.

[JmillsExpensify]

$500 approved for @allroundexperts