[$500] [Ideal Nav] Web - Web-OldDot Transition - Not here page shown when opening a free policy from OD

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.53-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4428043
Issue reported by: Applause - Internal Team

Action Performed:

1. Login to https://staging.expensify.com/
   with an account with at least on Free policy (can be added from ND)
2. Hover over Settings > Workspaces
3. Click on the Free policy

Expected Result:

You're redirected to NewDot, you're logged in with the same account as in OldDot and that the Workspace settings page is displayed

Actual Result:

Not found page is shown

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6417693_1710767505001.Recording__114.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e87bdd27eb99701d
• Upwork Job ID: 1770087739223650304
• Last Price Increase: 2024-03-19
• Automatic offers:
• eh2077 | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

@johncschuster I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[bernhardoj]

The transition has a exitTo params that contains a workspace route, workspace/{workspaceID}, but the recent ideal nav 2 PR updates the route to be settings/workspaces/{workspaceID}.

[johncschuster]

@kbecciv is this bug reproducible only when selecting a Free Plan? I ask because we intend on deprecating the Free Plan in Q1, so I'm not sure it's worth fixing this one unless the behavior is reproducible when opening a non-Free Plan.

Can you try testing that?

[trjExpensify]

Yeah, let's fix this. We're going to deploy the same method of redirecting different workspace plan types from OldDot to NewDot in short order. Starting with those that were formally of TYPE_FREE. CC: @WojtekBoman @adamgrzybowski @mountiny

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e87bdd27eb99701d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[trjExpensify]

@WojtekBoman is going to look at this: https://expensify.slack.com/archives/C036QM0SLJK/p1710856720495139?thread_ts=1710800292.533099&cid=C036QM0SLJK

[WojtekBoman]

Path to the workspace settings has been changed from /workspace/:id to settings/workspaces/:id, so we should update exitTo param when we open ND from OD. This problem might occur also when we navigate from OD to other workspace pages in ND which url starts with settings/workspaces/:id

[Piyush-Desai]

Hello @trjExpensify,

I hope this message finds you well.

I recently sent an email to request access to the Slack channel at contributors@expensify.com from my email address superherotigerfish@gmail.com.

I'm eager to contribute to resolving this bug, but I'm also quite new to this platform. If it's feasible on your end, could you kindly add me to the channel?

Your assistance would be greatly appreciated.

Thank you for considering my request.

[melvin-bot]

📣 @Piyush-Desai! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[trjExpensify]

We're going to need both internal and external changes for this one, so @WojtekBoman & @mountiny are going to pick it up as a ideal nav v2 follow-up.

[trjExpensify]

Hello @trjExpensify,

I hope this message finds you well.

I recently sent an email to request access to the Slack channel at contributors@expensify.com from my email address superherotigerfish@gmail.com.

👋 Hey @Piyush-Desai, thanks for joining our community! Someone will be in touch as a reply to your email to contributors@expensify.com in due course. In the meantime, feel free to check out our contributing guidelines.

[mountiny]

@WojtekBoman I think that the new route is being used for a while and the web transition should take you to the latest version so I think we can just move ahead without holding or waiting on anything. I made the backend PR for this

[mountiny]

The backend PR is merged and it will direct to the correct path now

[mountiny]

@WojtekBoman I am actually wondering if any App changes are needed here. again, this transition takes you to web, I feel like at the moment we do not have to worry that much about the old routes.

Basically that would be someone with desktop up which was not updated in 2+ weeks where they might get not found page. I dont think we have some standardized approach for this but I feel like we dont have to add more fixes for this

[WojtekBoman]

Ok, if anything happens, I have a branch with the solution ready

[trjExpensify]

@mountiny can we close this?

[mountiny]

yes