[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [POLISH][Simplified Collect] Create utils files for each page

[luacmartins]

Policy.ts is a large file and it'll only get larger and larger. We can keep the code more organized by separating each individual Members, Categories, Tags and Distance Rates into its own utils file, like we did for taxes here, i.e. /actions/Policy/TaxRates.ts, etc

[amyevans]

Started on this today, I'll split it up into a few PRs to make review a little easier.

Looking at Category to start, 1 clarifying question: Policy.ts contains category-related functions that are used by the Simplified Collect Category page (like openPolicyCategoriesPage), as well as others used when requesting money (like buildOptimisticPolicyRecentlyUsedCategories). I was going to move them all, but wanted to check that matches what you were thinking @luacmartins?

[luacmartins]

Yea, that makes sense.

[amyevans]

No update - haven't had much time to swing back around to this between some OOO and other commitments the past few days but will prioritize shortly

[melvin-bot]

@amyevans Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@amyevans Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@amyevans 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@amyevans 12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. @amyevans eroding to Weekly issue.

[amyevans]

Have been prioritizing a fast-apis issue and detailed design for the Billing card project. If anyone's interested in knocking this out feel free to take it from me, otherwise I'll work on it once I hit a lull in other work

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create Member.ts utils file #43066

If no regressions arise, payment will be issued on 2024-06-18. 🎊

[dangrous]

Did the migration solve the issue?

Unfortunately not. It's three functions that are causing the issue:

• removePendingFieldsFromCustomUnit defined in Policy.ts, used in Category.ts and DistanceRate.ts
• navigateWhenEnableFeature defined in Policy.ts, used in Policy.ts, Tag.ts, Category.ts, and DistanceRate.ts
• buildOptimisticPolicyCategories currently defined in BOTH Policy.ts and Category.ts, used in Policy.ts and Category.ts

Ideally we'd keep the first two where they are (in Policy.ts) and move the last one to ONLY Category.ts but that's posing the problem.

The last one makes the most sense to move or duplicate, since the top two are shared in multiple files (though the top two are also much shorter).

So maybe we leave it? Unless there's an additional file we could create with those and perhaps other utility methods or something like that.

[luacmartins]

Could we move the first 2 to PolicyUtils? For the buildOptimisticPolicyCategories, how does it create a circular dependency? I don't see Policy.ts importing Category.ts and vice-versa, so could we define it in Category.ts and then import Category in Policy.ts?

[dangrous]

Can't import category into policy (which it's not doing now) because category is already importing policy.

But moving those two into PolicyUtils should work, I can spin that up.

[luacmartins]

Can't import category into policy (which it's not doing now) because category is already importing policy.

Ah I missed the Policy import on Category the first time since it's importing specific functions. But the only imports from Policy are the 2 functions we're moving to PolicyUtils, no? So that means we can remove that Policy import in Category

[dangrous]

yep! that PR above should solve our problems

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create Member.ts utils file #43066

If no regressions arise, payment will be issued on 2024-06-20. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Shift around utils to deduplicate code without circular dependencies #43608

If no regressions arise, payment will be issued on 2024-06-24. 🎊

[dangrous]

No payment needed here but I'll close this on the 24th. Not expecting any regressions (though when ARE we expecting them?)

[luacmartins]

@dangrous I think we can close this issue since it's deployed to prod and was internal. We'll know if there's a regression haha

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Shift around utils to deduplicate code without circular dependencies #43608

If no regressions arise, payment will be issued on 2024-06-28. 🎊