[HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+fish101123@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Launch App
2. Navigate to WS Chat
3. Tap on [+] sign and select request money

Expected Result:

The request money page should be open

Actual Result:

App crashed when tap on request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418166_1710784757278.RPReplay_Final1710784130.mp4

log.txt

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this i issue.

iOS - App Crashed when tap on request money

What is the root cause of that problem?

regression from #38447. , the intl-pluralrules and intl-numberformat polyfill is needed for the Intl support in ios

https://github.com/abzokhattab/App/blob/dabcb166a9a0fba8dcbf2e11fe155c42b5eca678/src/libs/IntlPolyfill/index.native.ts

What changes do you think we should make in order to solve the problem?

• either we can we revert the change completely
• or we can revert the changes for only for the ios, as it seems to work with android:

to do that we can split the index.native file into two file one for android and one for ios:

• index.android.ts: should be the same as the current index.native.ts file
• index.ios.ts: should have the reverted change.

import polyfillListFormat from './polyfillListFormat';
import polyfillNumberFormat from './polyfillNumberFormat';
import type IntlPolyfill from './types';

/**
 * Polyfill the Intl API, always performed for native devices.
 */
const intlPolyfill: IntlPolyfill = () => {
    require('@formatjs/intl-locale/polyfill');
    require('@formatjs/intl-pluralrules/polyfill');
    polyfillNumberFormat();
    polyfillListFormat();
};

export default intlPolyfill;

then we should remove the index.native file

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[luacmartins]

It seems like #38502 (comment) has the same root cause as this issue. Given that #38502 was demoted to NAB, could we also test #38502 when we solve this one and close it if it's fixed?

[allgandalf]

I guess we need to take opinion of @mountiny here, as he had opened the issue #38447

[mountiny]

lets just revert that PR and handle these issues found in a v2.

We incorrectly assumed this will not be needed

[mountiny]

I would like to not rush these decisions

[mountiny]

I have made a revert PR here #38508

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "[NoQA][Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes on native platforms" #38508

If no regressions arise, payment will be issued on 2024-03-26. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "[NoQA][Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes on native platforms" #38508

If no regressions arise, payment will be issued on 2024-03-29. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes by separating iOS and android implementation #38565

If no regressions arise, payment will be issued on 2024-04-05. 🎊