Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent tags - Not here page opens when clicking on second level tag #38682

Closed
6 tasks done
lanitochka17 opened this issue Mar 20, 2024 · 19 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is admin of Collect workspace
  • The Collect workspace has multilevel dependent tags
  1. Go to staging.new.expensify.com
  2. Go to Profile > Workspaces > Collect workspace
  3. Go to Tags
  4. Click on the second level tag (North+test or South)

Expected Result:

Tag settings RHP opens without issue

Actual Result:

Not here page opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6420688_1710950667430.20240321_000225.mp4

Bug6420688_1710950667432!Dependent_-_Multi_Level_tags_NEW.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ed882f03ce5893b6
  • Upwork Job ID: 1771230284623380480
  • Last Price Increase: 2024-03-22
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 20, 2024
Copy link

melvin-bot bot commented Mar 20, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-control

@twisterdotcom
Copy link
Contributor

Precondition:
User is admin of Collect workspace
The Collect workspace has multilevel dependent tags

We are preventing this right @trjExpensify - so we can just close this? Or should we start solving these for Control?

@trjExpensify
Copy link
Contributor

You'll be able to have multi-level tags as a result of the QBO integration. Not dependent tags though, so we should fix that under the guise of #wave-control -- and generally support for them properly

@twisterdotcom
Copy link
Contributor

@JmillsExpensify I've put this in the Wave Control project, but I haven't put a status as I'm not sure when we want to support dependent tags. Gonna make it Weekly and assign Internal for now.

@twisterdotcom twisterdotcom added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Daily KSv2 labels Mar 22, 2024
Copy link

melvin-bot bot commented Mar 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ed882f03ce5893b6

Copy link

melvin-bot bot commented Mar 22, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rojiphil (Internal)

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@twisterdotcom
Copy link
Contributor

Given this probably won't be picked up until after May 1, gonna downgrade it to monthly.

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2024
@twisterdotcom twisterdotcom added Monthly KSv2 and removed Weekly KSv2 labels Apr 3, 2024
@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
@twisterdotcom
Copy link
Contributor

Still something we want to address in #wave-control when it comes to dependent tags.

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2024
@twisterdotcom
Copy link
Contributor

Is somebody internal already working on dependent tags now @trjExpensify?

@trjExpensify
Copy link
Contributor

Is somebody internal already working on dependent tags now @trjExpensify?

Not in #wave-collect. Ariel is progressing CSV import, incl. multiTags in #wave-control. So I expect dependent tags to be there if anywhere. CC: @JmillsExpensify

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@twisterdotcom
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2024
@twisterdotcom
Copy link
Contributor

@yuwenmemon I hear you are taking on Dependent Tags on newDot. Would you like to be assigned all of these glorious issues?

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2024
@yuwenmemon
Copy link
Contributor

Yes please!

@yuwenmemon yuwenmemon self-assigned this Aug 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 17, 2024
@yuwenmemon
Copy link
Contributor

yuwenmemon commented Sep 18, 2024

I'm actually unable to reproduce this. And since this bug is ancient @lanitochka17 can we please retest?

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2024
@twisterdotcom twisterdotcom added retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2 and removed Monthly KSv2 labels Sep 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2024
@twisterdotcom
Copy link
Contributor

Did we get a retest @lanitochka17?

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 8, 2024
@yuwenmemon
Copy link
Contributor

@lanitochka17 bump! 🙇🏽

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2024
@lanitochka17
Copy link
Author

Issue is not reproducible on the latest build 9.0.46-4

20241009_211758.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants