[HOLD for payment 2024-06-06] [$250] Concierge name shows up differently across users/clients

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.55-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): jpersaud@expensify.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @justinpersaud
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711045413582239

Action Performed:

1. Go to desktop and login
2. Observe how "Concierge" appears
3. Log in to web and check the "concierge" shows up
4. Login to SMS account in web

Expected Result:

Should show up as "Concierge" everywhere in product. It is important that as part of this change we do not revert back to having email notifications come from "Concierge" as the sender. All emails that we currently send from "Expensify Concierge" (concierge@expensify.com) should come from "Expensify" which is being handled here internally and we need to ensure that we don't break any other email logic such as how notifications in rooms or Group DMs are sent.

Actual Result:

In desktop shows up "Concierge" and web as "Expensify Concierge"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01341421c426bb4d52
• Upwork Job ID: 1772648999134048256
• Last Price Increase: 2024-04-22
• Automatic offers:
• akinwale | Reviewer | 0

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[zanyrenney]

Reassigning as I am OOO. I am back on April 2nd, so can take it back then if needed! Thanks.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MitchExpensify]

Checking what name is expected everywhere here https://expensify.slack.com/archives/C03TQ48KC/p1711404254318999?thread_ts=1699541323.795079&cid=C03TQ48KC

[MitchExpensify]

And double checking in #product https://expensify.slack.com/archives/C03U7DCU4/p1711406770617419

[MitchExpensify]

Ok update OP to:

Expected Result:

Should show up as "Concierge" everywhere in product. It is important that as part of this change we do not revert back to having emails come from "Concierge" as the sender. Emails should come from "Expensify" and we need to ensure that we don't break any other email logic such as how notifications in rooms or Group DMs are sent.

With regard to which Wave or VIP I think this could fit anywhere as polish and #wave-collect seems like as good a place as any

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01341421c426bb4d52

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[MitchExpensify]

Can this be handled externally @akinwale ?

[akinwale]

@MitchExpensify I believe the frontend changes can be handled externally.

All emails that we currently send from "Expensify Concierge" should come from "Expensify"

This however, would be a backend change.

[MitchExpensify]

Ok cool, maybe its best to split up the issues in that case

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Concierge name shows up differently across users/clients

What is the root cause of that problem?

We are showing the display name of report that is coming from API as it is.

What changes do you think we should make in order to solve the problem?

We can add the following line in getDisplayNameOrDefault function in PersonalDetailsUtils.ts file:

if(passedPersonalDetails?.accountID === CONST.ACCOUNT_ID.CONCIERGE) {
    displayName = 'CONCIERGE'
}

This will add change the name everywhere in the product.

Note

The hardcoded 'CONCIERGE' above will be stored as a CONST and used like that.

What alternative solutions did you explore? (Optional)

Result

Screenshots

1.   2.   3.   4.   5.

[FitseTLT]

Concierge name is consistent for desktop and web it is because the BE is returning Expensify Concierge on display Name If this needs to be fixed it should be fixed in BE 👍

[MitchExpensify]

Oh good catch @FitseTLT ! Making Internal in that case

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nexarvo You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[deetergp]

I will review this PR today.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show consistent name for 'Concierge'  #42067

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @nexarvo requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Reminder set to pay, lets tackle the BZ steps in the meantime @akinwale - Thank you!

[MitchExpensify]

Payment summary:

• $250 @akinwale requires payment automatic offer (Reviewer)
• $250 @nexarvo requires payment (Needs manual offer from BZ)

[MitchExpensify]

Paid @akinwale
Offer sent @nexarvo

[nexarvo]

@MitchExpensify offer accepted :)

[MitchExpensify]

Paid and contract ended, thanks @nexarvo!

@akinwale can you take a look at the BZ steps please?

[akinwale]

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps
Launch the Expensify app

Report

• Open the Expensify Concierge chat.
• Verify that Concierge is displayed as the name in the report including the header.
• Click on the header.
• In the report details page verify that the display name is shown as Concierge.

LHN

• In the LHN confirm that Concierge is displayed as the name for the Expensify Concierge chat report.

Search

• Click on search icon at top of LHN.
• Search for Concierge
• Verify that the display name of the report is Concierge.

Composer

• Open any report
• In the composer, type '@concierge@expensify.com'
• Verify that the display name for the mention result is Concierge

Do we agree 👍 or 👎?

[deetergp]

Regression steps look good to me.

[MitchExpensify]

Nice! Issue created to add steps