Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-05] [Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate #38815

Closed
6 tasks done
lanitochka17 opened this issue Mar 22, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is admin of Collect workspace
  1. Go to staging.new.expensify.com
  2. Go to Profile > Workspaces > Collect workspace
  3. Go to Distance rates
  4. Add a distance rate
  5. Click on the distance rate added in Step 4
  6. Toggle off the Enable rate button
  7. Click Rate and edit the rate

Expected Result:

App will save the new settings made in Step 6 and 7

Actual Result:

Error shows up when disabling and renaming distance rate

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423392_1711126287997.20240323_004850.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 22, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 22, 2024

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-control

@lanitochka17
Copy link
Author

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@luacmartins luacmartins moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 22, 2024
@luacmartins luacmartins changed the title Distance rates - Error shows up when disabling and renaming distance rate [Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate Mar 22, 2024
@luacmartins
Copy link
Contributor

This is not a blocker since this feature is not available to users yet.

@luacmartins
Copy link
Contributor

cc @MrMuzyk

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 22, 2024
@luacmartins
Copy link
Contributor

This is the error that I get. This was already fixed here
Screenshot 2024-03-22 at 4 47 14 PM

@luacmartins luacmartins added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 29, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate [HOLD for payment 2024-04-05] [Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate Mar 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-05. 🎊

Copy link

melvin-bot bot commented Apr 5, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@luacmartins
Copy link
Contributor

This is done

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants