[HOLD for payment 2024-05-02] [VIP-VSB] Thumbnail - Thumbnail of a markdown image flickers

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Send a markdown image to a user you don’t have a chat history with
2. Navigate to another chat
3. Navigate back to the report

Expected Result:

Thumbnail of a markdown image shouldn’t flicker

Actual Result:

Thumbnail of a markdown image flickers

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423407_1711126961939.Screen_Recording_2024-03-22_at_7.56.48_in_the_evening.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sobitneupane

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[situchan]

cc: @kidroca

[arosiclair]

Looks like a new feature (#37566) so probably doesn't need to be a blocker. cc @kidroca @marcaaron

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kidroca]

I'm investigating

[kidroca]

Currently, it appears that the issue isn't related to the PR, as I've tested the functionality prior to merging PR #37566 and encountered the same problem with regular attachments. I'm in the process of identifying when exactly the issue first arose.

[kidroca]

I've traced the bug using git bisect down to 3fbbb19 and #30269

[strepanier03]

Thank you, @kidroca.

Should I assign this to you? Based on what I've found in Slack, I'm going to tie this to VIP-VSB.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Cache measured sizes in ThumbnailImage #40643

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @janicduplessis does not require payment (Contractor)
• @situchan requires payment - $500 (offer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
• [@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@janicduplessis / @situchan] Determine if we should create a regression test for this bug.
• [@janicduplessis / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jose-valentin-git]

I have checked this issue on Video recording.
My technical apporach:

• Implement enhanced caching strategies for image thumbnails to reduce load times and prevent re-rendering flickers. Utilize React Native's built-in caching mechanisms more effectively or integrate a more robust custom caching solution.
• Modify the lifecycle methods of the image display component to prevent unnecessary re-renders. Employ shouldComponentUpdate or React's PureComponent to ensure components only update when new props affecting the image are received.
• Ensure state transitions related to chat navigation are handled smoothly, possibly by implementing a global state management solution like Redux or Context API to keep track of image loading states across components.

Contributor details
jose.valentin.biz@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016348897c58480195

[melvin-bot]

📣 @jose-valentin-git! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[strepanier03]

@janicduplessis @situchan - Can one of you complete the checklist steps below so I can wrap this up?

• [@janicduplessis / @situchan] Determine if we should create a regression test for this bug.
• [@janicduplessis / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @janicduplessis is from an agency-contributor and not due payment
• ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sobitneupane]

I reviewed #40643 PR @strepanier03 Can you please assign me the issue.

[melvin-bot]

@janicduplessis, @strepanier03, @marcaaron, @situchan Eep! 4 days overdue now. Issues have feelings too...

[strepanier03]

Did @situchan also work on this? Do you know @sobitneupane?

[strepanier03]

@sobitneupane - Can you complete the two @situchan originally?

• [@janicduplessis / @situchan] Determine if we should create a regression test for this bug.
• [@janicduplessis / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Thanks!

[strepanier03]

I also sent you an offer @sobitneupane, let me know if I need to cancel that if you use Manual Requests normally.

[marcaaron]

bump @sobitneupane

[melvin-bot]

@janicduplessis, @strepanier03, @sobitneupane, @marcaaron, @situchan Eep! 4 days overdue now. Issues have feelings too...

[sobitneupane]

Regression Test Proposal

1. Add an image using markdown ![https://hatrabbits.com/wp-content/uploads/2017/01/random.jpg](https://hatrabbits.com/wp-content/uploads/2017/01/random.jpg)
2. Reload the page and switch between chats,
3. Verify that thumbnail of the markdown image doesn't flicker (with an exception of first load/time)

Do we agree 👍 or 👎

[sobitneupane]

I also sent you an offer @sobitneupane, let me know if I need to cancel that if you use Manual Requests normally.

@strepanier03 I will request the payment in newDot.

[strepanier03]

Thanks @sobitneupane - I'll cancel the job in Upwork, finish the reg test, and post the payment summary for your ND request.

[strepanier03]

Reg test done, job closed in Upwork.

[strepanier03]

Payment Summary

• @sobitneupane - $500 via Manual Requests

Heads up @JmillsExpensify - Request incoming for payment!

[JmillsExpensify]

$500 approved for @sobitneupane