[HOLD for payment 2024-04-05] [Simplified Collect][Taxes] - Tax rate editor is not auto-focused

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is admin of Collect workspace.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Taxes.
4. Add a tax rate.
5. Click on the tax rate added in Step 4.
6. Click Value.

Expected Result:

The tax rate editor will be auto-focused.

Actual Result:

The tax rate editor is not auto-focused.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423420_1711127534361.20240323_011019.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-control

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kosmydel]

This PR addresses this issue.

[abbasifaizan70]

Re-stated Problem:
The auto-focus feature on the tax rate editor is not functioning as expected. When a user clicks on the tax rate value, the input field should automatically gain focus, but it currently does not.

Root Cause:
The issue likely stems from the ref (inputCallbackRef) not being properly forwarded to the native input element within the AmountForm component. The useAutoFocusInput hook seems to be intended for this purpose, but if the child component does not correctly implement forwardRef or does not pass the ref down to the actual DOM element, the focus method will not be triggered.

Proposed Solution:
Ensure that the AmountForm component (or whichever component is wrapped by InputWrapper) properly implements the forwarding of refs using React.forwardRef and useImperativeHandle. Here's an outline of changes:

Modify the AmountForm component to accept a ref and use useImperativeHandle to forward this ref to the actual input element.
Ensure the inputCallbackRef is passed to the InputWrapper and consequently to the AmountForm.
Confirm that the lifecycle of the component aligns with when the auto-focus should be triggered, possibly using the useEffect hook if necessary.

Pseudo-code Example:

// AmountForm component
const AmountForm = React.forwardRef((props, ref) => {
  const inputRef = React.useRef();
  React.useImperativeHandle(ref, () => ({
    focus: () => {
      inputRef.current.focus();
    },
  }));

  return <input ref={inputRef} {...props} />;
});

// Usage in ValuePage
<InputWrapper
  InputComponent={AmountForm}
  ref={inputCallbackRef}
  // ...other props
/>

Alternatives Explored:
An alternative solution might be to manually trigger the focus on the input element via a side effect when the component mounts or updates, without using useAutoFocusInput, but this would be less reusable and might not align with the existing design patterns in the codebase.

Contributor details
Your Expensify account email: abbasi.faizan1997@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/faizanabbasi70

[melvin-bot]

📣 @abbasifaizan70! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[abbasifaizan70]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

Contributor details
Your Expensify account email: abbasi.faizan1997@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/faizanabbasi70

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[luacmartins]

Demoting to NAB

[luacmartins]

I can take this since it's part of Simplified Collect

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Auto focus Tax value input #38843

If no regressions arise, payment will be issued on 2024-04-05. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

@sonialiap could you please assist with payment since @s77rt reviewed the linked PR?

[sonialiap]

All looks good, processing payment

@s77rt $500 - offer sent

[s77rt]

@sonialiap Accepted! Thanks!

[sonialiap]

Paid ✔️