Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate remaining FlatList files to TypeScript #38919

Closed
fabioh8010 opened this issue Mar 25, 2024 · 19 comments
Closed

[TS migration] Migrate remaining FlatList files to TypeScript #38919

fabioh8010 opened this issue Mar 25, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Typescript Migration

Comments

@fabioh8010
Copy link
Contributor

fabioh8010 commented Mar 25, 2024

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

  • src/components/FlatList/index.web.js
  • src/components/FlatList/MVCPFlatList.js
Issue OwnerCurrent Issue Owner: @anmurali
@fabioh8010 fabioh8010 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@fabioh8010
Copy link
Contributor Author

This issue is internal and will be handled by the TS team.

@war-in
Copy link
Contributor

war-in commented Mar 25, 2024

Hi, I'm Marcin from Software Mansion and I would like to work on this issue

Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Apr 19, 2024
Copy link

melvin-bot bot commented Apr 19, 2024

This issue has not been updated in over 15 days. @Beamanator, @anmurali eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 19, 2024
@Beamanator
Copy link
Contributor

Ooh this got merged & is on prod as of a week ago, is payment due?

@fedirjh
Copy link
Contributor

fedirjh commented Apr 19, 2024

@Beamanator Can you please assign me so that I keep track of the payment for the C+ review? Thank You

@Beamanator
Copy link
Contributor

Done!

@blazejkustra
Copy link
Contributor

What are the next steps here? Should we close this issue?

@Beamanator
Copy link
Contributor

Gooood question, @anmurali I believe payment is due here, yeah?

I think the Reviewing label has made it hard for us to see that this needs action (using K2)

@Beamanator Beamanator added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Monthly KSv2 labels May 16, 2024
@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@Beamanator Beamanator added Weekly KSv2 and removed Daily KSv2 labels May 21, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 21, 2024
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels May 22, 2024
@fedirjh
Copy link
Contributor

fedirjh commented May 27, 2024

@anmurali friendly bump

Copy link

melvin-bot bot commented May 27, 2024

@Beamanator, @anmurali, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented May 29, 2024

@Beamanator, @anmurali, @fedirjh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented May 31, 2024

@Beamanator, @anmurali, @fedirjh 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@anmurali
Copy link

anmurali commented Jun 4, 2024

@fedirjh - offer is here

@melvin-bot melvin-bot bot removed the Overdue label Jun 4, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Jun 4, 2024

@anmurali Thank you. Accepted.

@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

@Beamanator, @anmurali, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jun 11, 2024

@Beamanator, @anmurali, @fedirjh Still overdue 6 days?! Let's take care of this!

@anmurali
Copy link

Paid.

@melvin-bot melvin-bot bot removed the Overdue label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Typescript Migration
Projects
Development

No branches or pull requests

7 participants