Android - Attachments Preview - Header overlaps Android top status bar

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Send an image as attachment
3. Click on it in order to have larger preview

Expected Result:

Preview is shown and there are no design breaks

Actual Result:

It does not happen with all headers, I could only identify this one
On devices with notch, it will be even more visible

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.75-5
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Issue reproduced in Moto G7 and Galaxy S10
Note from tester:

It does not happen with all headers, I could only identify this one
On devices with notch, it will be even more visible

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

This can definitely be external

[MelvinBot]

Triggered auto assignment to @marklouisdeshaun (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[rdjuric]

Proposal

Looks like we're setting statusBarTranslucent to our ReactNativeModal, which makes the Modal go under the StatusBar. Removing this prop give us the desired behavior.

video.mp4

I think we needed this prop when we were using a translucent StatusBar in the whole app to avoid a UI jump, but now that we're using a solid StatusBar this is legacy.

[roryabraham]

Solution looks good @rdjuric. Feel free to submit a PR as soon as you've been hired on Upwork. @marklouisdeshaun Please post the link to the Upwork job once it's created, and then feel free to hire @rdjuric once he's applied.

[marklouisdeshaun]

Upwork job post

[rdjuric]

Applied to the job @marklouisdeshaun!

[marklouisdeshaun]

Thanks! Offer sent @rdjuric

[roryabraham]

PR merged. Nice quick turnaround here @rdjuric @marklouisdeshaun!

[isagoico]

Issue not reproducible during KI retests (Fixed 🎉)

[marklouisdeshaun]

Paid and closed in Upwork. Thanks @rdjuric!