Distance rates - Empty space between distance rates after deleting and adding distance rate

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.57-2
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38799
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is admin of Collect workspace.
• There is only one distance rate in the workspace.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Distance rates.
   4, Add a distance rate.
4. Delete the distance rate in Step 4.
5. Add another distance rate.

Expected Result:

There will be no spacing between first and second distance rate.

Actual Result:

There is spacing between first and second distance rate.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6428885_1711555306485.20240327_235425.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-control

[ZhenjaHorbach]

Regression from this PR
#38454

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rates - Empty space between distance rates after deleting and adding distance rate

What is the root cause of that problem?

The main problem with the issue is that when we remove distance rates item we hide an element, but after the last PR we add a margin for all elements (even when this element is hidden, but not yet completely removed )

App/src/components/SelectionList/TableListItem.tsx

Line 36 in e89a1e4

containerStyle={styles.mb3}

What changes do you think we should make in order to solve the problem?

To fix this issue we can add new prop for BaseListItem (contentContainerStyle)

App/src/components/SelectionList/TableListItem.tsx

Line 32 in e89a1e4

<BaseListItem

Then pass this new prop for OfflineWithFeedback (Inside OfflineWithFeedback we already use this prop )

App/src/components/SelectionList/BaseListItem.tsx

Line 61 in e89a1e4

<OfflineWithFeedback

And we need to update this line (In this case, we will add styles only for visible elements)

contentContainerStyle={styles.mb3}

App/src/components/SelectionList/TableListItem.tsx

Line 36 in e89a1e4

containerStyle={styles.mb3}

What alternative solutions did you explore? (Optional)

NA

[thienlnam]

Not a blocker / @Krishna2323 & @rushatgabhane Are you able to spin up a PR for this?

[ZhenjaHorbach]

If no one answers, I can )

[rushatgabhane]

@thienlnam gimme a moment, I'll send a fix

[Krishna2323]

@rushatgabhane, sorry, I was writing a proposal, pls let me handle this if you haven't started since it came from my PR :)

[rushatgabhane]

@Krishna2323 yes please go ahead, that'd be great! 🙇‍♂️

[Krishna2323]

@thienlnam, I looked into the code and it appears to be a problem with OfflineWithFeedback component. I need sometime to get to a solution without any regression. Is that okay? Will probably raise a PR tomorrow.

[thienlnam]

Yeah, not a problem - thanks!

[Krishna2323]

@rushatgabhane, PR ready for review. Sorry for delay, I was blocked by this issue.

[melvin-bot]

This issue has not been updated in over 15 days. @rushatgabhane, @thienlnam, @Krishna2323 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@rushatgabhane, @thienlnam, @Krishna2323, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.