[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [TS Migration] Add comments for remaining properties in Onyx types

[mountiny]

Follow up issue for TS migration project. Coming from this spreadsheet

Add comments for remaining properties in Onyx types

Any more details for this one cc @blazejkustra @fabioh8010

Issue Owner

Current Issue Owner: @stephanieelliott

[fabioh8010]

This issue will be handled internally - we are deciding who is going to pick

[pac-guerreiro]

@fabioh8010 @mountiny

I can work on this! 😄

[fabioh8010]

@pac-guerreiro Any updates here? What is the ETA for a Draft PR?

[melvin-bot]

This issue has not been updated in over 15 days. @pac-guerreiro eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fabioh8010]

A WIP Draft PR was created here -> #41956

[melvin-bot]

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[mountiny]

@pac-guerreiro, can you please address the follow-ups I have mentioned in the PR? thanks!

[pac-guerreiro]

@mountiny I just opened a PR with the addressed follow-ups -> #43499 😄

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA][TS Migration] Add comments for remaining properties in Onyx types #41956

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@pac-guerreiro] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA][TS Migration] Add comments for remaining properties in Onyx types #41956

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@pac-guerreiro] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mountiny]

No payments required here