Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] IOU - RBR appears then disappears from IOU preview component & LHN #39174

Closed
4 of 6 tasks
kbecciv opened this issue Mar 28, 2024 · 64 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #37875
Issue reported by: Applause - Internal team

Action Performed:

  1. On the main device, create an IOU with secondary device user
  2. On the secondary device, settle the payment
  3. On the main device, make a second request right after secondary device settles the request

Expected Result:

RBR should remain on IOU preview component, and LHN of the main report until it is cleared

Actual Result:

RBR fades away from IOU preview component, and LHN after few seconds

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6430008_1711623192968.Screen_Recording_2024-03-28_at_12.48.30_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0162848aad35917395
  • Upwork Job ID: 1776390018885652480
  • Last Price Increase: 2024-09-04
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 28, 2024

We think that this bug might be related to #wave-collect - Release 1

@kbecciv
Copy link
Author

kbecciv commented Mar 28, 2024

@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@kevinksullivan
Copy link
Contributor

This wold go in split, so I'll add it to that project and push forward.

@melvin-bot melvin-bot bot removed the Overdue label Apr 5, 2024
@kevinksullivan kevinksullivan added the External Added to denote the issue can be worked on by a contributor label Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0162848aad35917395

@melvin-bot melvin-bot bot changed the title IOU - RBR appears then disappears from IOU preview component & LHN [$250] IOU - RBR appears then disappears from IOU preview component & LHN Apr 5, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@VickyStash
Copy link
Contributor

I did some investigations, and that's what I've found out. The reason for RBR disappearing with the described flow is that the money request is turned into settled and the app doesn't show RBR for settled money requests.

const shouldShowRBR = !iouSettled && hasErrors;

This logic was implemented as a requirement for this issue in the related PR.

Overall it looks like expected behavior, but if we want to define more specific cases when we want to show RBR indicators for settled money requests we need to know the requirements.

Copy link

melvin-bot bot commented Apr 9, 2024

@kevinksullivan, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Apr 11, 2024

@kevinksullivan @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Apr 11, 2024

@kevinksullivan, @getusha Eep! 4 days overdue now. Issues have feelings too...

@kevinksullivan
Copy link
Contributor

@getusha since you are working on another project should we reassign this?

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2024
@getusha
Copy link
Contributor

getusha commented Apr 11, 2024

Overall it looks like expected behavior, but if we want to define more specific cases when we want to show RBR indicators for settled money requests we need to know the requirements.

@kevinksullivan, @VickyStash is suggesting that this is an expected behavior.
cc @aldo-expensify @c3024 @abdulrahuman5196 for confirmation.

Copy link

melvin-bot bot commented Apr 12, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

@kevinksullivan, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Apr 17, 2024

@kevinksullivan, @getusha Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Apr 19, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@kevinksullivan
Copy link
Contributor

asking about this bug in slack

https://expensify.slack.com/archives/C05RECHFBEW/p1713548212648119

@kevinksullivan kevinksullivan added Daily KSv2 and removed Monthly KSv2 labels Jul 30, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

@kevinksullivan, @getusha Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Aug 7, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 7, 2024

@kevinksullivan, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Aug 9, 2024

@kevinksullivan, @getusha 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@kevinksullivan
Copy link
Contributor

Awaiting proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 9, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

@kevinksullivan, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Aug 14, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 15, 2024

@kevinksullivan, @getusha Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Aug 19, 2024

@kevinksullivan, @getusha Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Aug 21, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 21, 2024

@kevinksullivan, @getusha 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Aug 23, 2024

@kevinksullivan, @getusha 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 26, 2024
Copy link

melvin-bot bot commented Aug 26, 2024

This issue has not been updated in over 14 days. @kevinksullivan, @getusha eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Sep 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2024
@kevinksullivan
Copy link
Contributor

asking for re-test as it's been a while

https://expensify.slack.com/archives/C9YU7BX5M/p1725472285004789

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@luacmartins
Copy link
Contributor

I think we can close this one since it's not reproducible anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants