[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Thread - App shows skeleton loading when clicking on parent/ancestor message offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38722
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat.
3. Go offline.
4. Send a message.
5. Create several threads in the parent message.
6. Click on any parent or ancestor message.

Expected Result:

App will redirect to the relevant thread without skeleton loading.

Actual Result:

App shows infinite skeleton loading when clicking on parent/ancestor message offline.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431721_1711726259481.20240329_232816.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[arosiclair]

I reproduced. It seems like navigation back to the parent does not work while offline. @rayane-djouah @allroundexperts @chiragsalian can any of you guys take a look?

[arosiclair]

Seems like it's due to reportMetadata.isLoadingInitialReportActions being stuck to true

[rayane-djouah]

We used comment linking feature in the "Thread" and header links to navigate directly to the message as requested here: #38722 (comment). Seems like comment linking requires connectivity. I think that in offline mode we should navigate to the report when clicking the links like we used to do before. Do you agree @allroundexperts ?
I will raise a follow up PR.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[rayane-djouah]

Partial revert merged : #39302

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[marcaaron]

Gonna remove the blocker because the revert PR above appears to have fixed this and was CP'd.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert using comment linking in threads #39302

If no regressions arise, payment will be issued on 2024-04-09. 🎊

[arosiclair]

Handled in another issue.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert using comment linking in threads #39302

If no regressions arise, payment will be issued on 2024-04-15. 🎊