Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark down - Different colour of strikethrough on email depending on bold mark down position #39266

Closed
3 of 6 tasks
lanitochka17 opened this issue Mar 29, 2024 · 7 comments
Closed
3 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR around #38152

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat.
  3. Type the following text with mark down (with no space):
  • ~ hello.com ~ *
    ~ * hello.com * ~

Expected Result:

The color of strikethrough in the preview should be consistent

Actual Result:

The color of strikethrough in the preview is different depending on the position of bold mark down.
When the mark down is in this order * ~ hello.com ~ *, the strikethrough is blue
When the mark down is in this order ~ * hello.com * ~, the strikethrough is white

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431683_1711724092674.20240329_225011.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@flodnv FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@thienlnam thienlnam added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 29, 2024
@thienlnam thienlnam assigned thienlnam and unassigned flodnv Mar 29, 2024
@thienlnam
Copy link
Contributor

Not a deploy blocker - added to the main tracking issue

@thienlnam
Copy link
Contributor

This is pretty low on the priority list of other live markdown issues, so going to put this on a monthly

@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@thienlnam
Copy link
Contributor

Closing, looking at this again I'm not sure there is really a problem here

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants